Source/bindings/v8/V8HiddenPropertyName.h - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8HiddenPropertyName.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Large set of fixes from adamk and haraken. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/custom-event-isolated-world.html ('K') | « Source/bindings/v8/Dictionary.cpp ('k') | Source/bindings/v8/custom/V8CustomEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8HiddenPropertyName.h

diff --git a/Source/bindings/v8/V8HiddenPropertyName.h b/Source/bindings/v8/V8HiddenPropertyName.h

index 7bd60edc733ebde5582d3394f904b5489bebe23d..cff374eb6f2e9f42c925f5933ad01a1e89c1b011 100644

--- a/Source/bindings/v8/V8HiddenPropertyName.h

+++ b/Source/bindings/v8/V8HiddenPropertyName.h

@@ -39,6 +39,7 @@ namespace WebCore {

V(adaptorFunctionPeer) \

V(attributeListener) \

V(callback) \

+ V(data) \

haraken 2013/06/25 02:06:58 Would you use a more specific variable name?

jww 2013/06/26 02:27:06 I just used the same name as is used in MessageEve

haraken 2013/06/26 04:02:31 Makes sense. Let's leave it as is:)

V(detail) \

V(document) \

V(event) \