Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: Source/bindings/v8/V8HiddenPropertyName.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Large set of fixes from adamk and haraken. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 #define V8HiddenPropertyName_h 32 #define V8HiddenPropertyName_h
33 33
34 #include <v8.h> 34 #include <v8.h>
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 #define V8_HIDDEN_PROPERTIES(V) \ 38 #define V8_HIDDEN_PROPERTIES(V) \
39 V(adaptorFunctionPeer) \ 39 V(adaptorFunctionPeer) \
40 V(attributeListener) \ 40 V(attributeListener) \
41 V(callback) \ 41 V(callback) \
42 V(data) \
haraken 2013/06/25 02:06:58 Would you use a more specific variable name?
jww 2013/06/26 02:27:06 I just used the same name as is used in MessageEve
haraken 2013/06/26 04:02:31 Makes sense. Let's leave it as is:)
42 V(detail) \ 43 V(detail) \
43 V(document) \ 44 V(document) \
44 V(event) \ 45 V(event) \
45 V(isCustomElementInterfacePrototypeObject) \ 46 V(isCustomElementInterfacePrototypeObject) \
46 V(listener) \ 47 V(listener) \
47 V(name) \ 48 V(name) \
48 V(namespaceURI) \ 49 V(namespaceURI) \
49 V(scriptState) \ 50 V(scriptState) \
50 V(sleepFunction) \ 51 V(sleepFunction) \
51 V(state) \ 52 V(state) \
(...skipping 13 matching lines...) Expand all
65 private: 66 private:
66 static void createString(const char* key, v8::Persistent<v8::String>* handle ); 67 static void createString(const char* key, v8::Persistent<v8::String>* handle );
67 #define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name; 68 #define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name;
68 V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD); 69 V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
69 #undef V8_DECLARE_FIELD 70 #undef V8_DECLARE_FIELD
70 }; 71 };
71 72
72 } 73 }
73 74
74 #endif // V8HiddenPropertyName_h 75 #endif // V8HiddenPropertyName_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698