LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed some test failures, fixed some nits, and generalized the new events test. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/constructors/custom-event-constructor.html ('k') | LayoutTests/fast/events/event-isolated-world.html » ('j') | LayoutTests/fast/events/event-isolated-world.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt

diff --git a/LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt b/LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt

index 88b90aacfe4f1225ae54d36af43f059a632c827d..9cff9ce5f96de51bf34a91a0a1c2cbb8d590a47b 100644

--- a/LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt

+++ b/LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt

@@ -13,6 +13,8 @@ PASS new CustomEvent('eventType', { detail: 10 }).detail is 10

PASS new CustomEvent('eventType', { detail: 'string' }).detail is 'string'

PASS new CustomEvent('eventType', { detail: detailObject }).detail is detailObject

PASS new CustomEvent('eventType', { detail: document }).detail is document

+PASS new CustomEvent('eventType', { detail: undefined }).detail is undefined

+PASS new CustomEvent('eventType', { detail: null }).detail is null

haraken 2013/06/26 04:02:31 Would you add similar test cases for PopStateEvent

jww 2013/06/26 17:19:08 They already have similar test cases; I was just a

PASS new CustomEvent('eventType', { get detail() { return true; } }).detail is true

PASS new CustomEvent('eventType', { get detail() { throw 'Custom Error'; } }) threw exception Custom Error.

PASS successfullyParsed is true