LayoutTests/fast/events/constructors/custom-event-constructor.html - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/constructors/custom-event-constructor.html

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed some test failures, fixed some nits, and generalized the new events test. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt » ('j') | LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/constructors/custom-event-constructor.html

diff --git a/LayoutTests/fast/events/constructors/custom-event-constructor.html b/LayoutTests/fast/events/constructors/custom-event-constructor.html

index be5547d8f7e375736323ed189dd48870e67e2186..75d882f2597cd72d6b9c1649ee2a41bf1592eed7 100644

--- a/LayoutTests/fast/events/constructors/custom-event-constructor.html

+++ b/LayoutTests/fast/events/constructors/custom-event-constructor.html

@@ -31,6 +31,12 @@ shouldBe("new CustomEvent('eventType', { detail: detailObject }).detail", "detai

// Detail is a DOM object

shouldBe("new CustomEvent('eventType', { detail: document }).detail", "document");

+// Detail is undefined.

+shouldBe("new CustomEvent('eventType', { detail: undefined }).detail", "undefined");

+// Detail is null.

+shouldBe("new CustomEvent('eventType', { detail: null }).detail", "null");

// Detail is a getter.

shouldBe("new CustomEvent('eventType', { get detail() { return true; } }).detail", "true");