Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1706263002: MIPS: [Interpreter] Implements calls through CallICStub in the interpreter.

Created:
4 years, 10 months ago by balazs.kilvady
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [Interpreter] Implements calls through CallICStub in the interpreter. Port for https://codereview.chromium.org/1688283003/ Original commit message: Calls are implemented through CallICStub to collect type feedback. Adds a new builtin called InterpreterPushArgsAndCallIC that pushes the arguments onto stack and calls CallICStub. Also adds two new bytecodes CallIC and CallICWide to indicate calls have to go through CallICStub. BUG=v8:4280, v8:4680 LOG=N

Patch Set 1 #

Patch Set 2 : Adds tail call support for CallIC. #

Total comments: 2

Patch Set 3 : Fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -65 lines) Patch
M src/mips/builtins-mips.cc View 1 4 chunks +66 lines, -13 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 7 chunks +31 lines, -17 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 3 chunks +66 lines, -12 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 6 chunks +37 lines, -23 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
mythria
Thanks for the port. lgtm. https://codereview.chromium.org/1706263002/diff/20001/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/1706263002/diff/20001/src/mips/code-stubs-mips.cc#newcode2352 src/mips/code-stubs-mips.cc:2352: // Push a0, the ...
4 years, 10 months ago (2016-02-19 09:36:26 UTC) #3
balazs.kilvady
4 years, 10 months ago (2016-02-19 11:39:56 UTC) #4
https://codereview.chromium.org/1706263002/diff/20001/src/mips/code-stubs-mip...
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/1706263002/diff/20001/src/mips/code-stubs-mip...
src/mips/code-stubs-mips.cc:2352: // Push a0, the receiver, the function and
feedback info.
On 2016/02/19 09:36:25, mythria wrote:
> may be we can replace a0 by number of arguments in the comment. 

Done.

Powered by Google App Engine
This is Rietveld 408576698