Tune Array.forEach, fix Array functions

Tune Array.forEach, fix Array functions

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
This patch also fixes the HAS_INDEX macro used in a bunch of
Array.prototype functions to properly check for elements inherited
from prototypes.

Committed: https://crrev.com/01d228f3cd0125250bb94f1330f9c697568a4768
Cr-Commit-Position: refs/heads/master@{#34269}

[Jakob Kummerow, 2016-02-18 15:04:39]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2016-02-18 15:04:39]

This appears to give about 1-7% on a microbenchmark (hard to be sure due to
flakiness). Do you think that's significant enough to land it?

We could probably get a little more speedup by implementing the entire .forEach
builtin as a TF stub. We'll hit a brick wall at around 10-20% improvement due to
the function call overhead though.

For a real speed boost (80-90% reduction in time), we'd have to add compiler
support for .forEach and make sure we inline the callback. That's probably a
project for TF's distant future.

[Jakob Kummerow, 2016-02-18 16:13:02]

New patch set fixes elements inherited from prototypes, PTAL.

[Jakob Kummerow, 2016-02-18 16:13:41]

Description was changed from

==========
Tune Array.forEach

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
==========

to

==========
Tune Array.forEach, fix Array functions

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
This patch also fixes the HAS_INDEX macro used in a bunch of
Array.prototype functions to properly check for elements inherited
from prototypes.
==========

[adamk, 2016-02-18 17:43:32]

https://codereview.chromium.org/1706213002/diff/20001/src/js/array.js
File src/js/array.js (right):

https://codereview.chromium.org/1706213002/diff/20001/src/js/array.js#newcode...
src/js/array.js:1260: if (IS_UNDEFINED(receiver)) {
FWIW we used to do something even fancier, but bmeurer removed it in
https://codereview.chromium.org/1325573004/diff/60001/src/array.js (partly
because it wasn't entirely correct).

[Toon Verwaest, 2016-02-24 09:09:04]

lgtm

https://codereview.chromium.org/1706213002/diff/20001/src/js/array.js
File src/js/array.js (right):

https://codereview.chromium.org/1706213002/diff/20001/src/js/array.js#newcode...
src/js/array.js:1260: if (IS_UNDEFINED(receiver)) {
On 2016/02/18 17:43:32, adamk wrote:
> FWIW we used to do something even fancier, but bmeurer removed it in
> https://codereview.chromium.org/1325573004/diff/60001/src/array.js (partly
> because it wasn't entirely correct).

That code was quite different. The bug there iirc comes from the TO_OBJECT
that's both invalidly cached and created in the wrong context.

[Jakob Kummerow, 2016-02-25 05:20:09]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-02-25 05:20:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706213002/20001

[commit-bot: I haz the power, 2016-02-25 05:42:42]

Description was changed from

==========
Tune Array.forEach, fix Array functions

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
This patch also fixes the HAS_INDEX macro used in a bunch of
Array.prototype functions to properly check for elements inherited
from prototypes.
==========

to

==========
Tune Array.forEach, fix Array functions

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
This patch also fixes the HAS_INDEX macro used in a bunch of
Array.prototype functions to properly check for elements inherited
from prototypes.
==========

[commit-bot: I haz the power, 2016-02-25 05:42:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-25 05:43:53]

Description was changed from

==========
Tune Array.forEach, fix Array functions

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
This patch also fixes the HAS_INDEX macro used in a bunch of
Array.prototype functions to properly check for elements inherited
from prototypes.
==========

to

==========
Tune Array.forEach, fix Array functions

When there is no receiver object, plain function calls are a few
percent faster than %_Call().
This patch also fixes the HAS_INDEX macro used in a bunch of
Array.prototype functions to properly check for elements inherited
from prototypes.

Committed: https://crrev.com/01d228f3cd0125250bb94f1330f9c697568a4768
Cr-Commit-Position: refs/heads/master@{#34269}
==========

[commit-bot: I haz the power, 2016-02-25 05:43:55]

Patchset 2 (id:??) landed as
https://crrev.com/01d228f3cd0125250bb94f1330f9c697568a4768
Cr-Commit-Position: refs/heads/master@{#34269}