src/js/macros.py - Issue 1706213002: Tune Array.forEach, fix Array functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/macros.py

Issue 1706213002: Tune Array.forEach, fix Array functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: correctify inherited elements Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/macros.py

diff --git a/src/js/macros.py b/src/js/macros.py

index 94c9b9479b81f3d20a5bde78b479244ede75c4f8..e192d51296846a45404b8f5e430bb117d0d260e3 100644

--- a/src/js/macros.py

+++ b/src/js/macros.py

@@ -123,7 +123,7 @@ macro TO_PRIMITIVE_STRING(arg) = (%_ToPrimitive_String(arg));

macro TO_NAME(arg) = (%_ToName(arg));

macro JSON_NUMBER_TO_STRING(arg) = ((%_IsSmi(%IS_VAR(arg)) || arg - arg == 0) ? %_NumberToString(arg) : "null");

macro HAS_OWN_PROPERTY(arg, index) = (%_Call(ObjectHasOwnProperty, arg, index));

-macro HAS_INDEX(array, index, is_array) = ((is_array && %_HasFastPackedElements(%IS_VAR(array))) ? (index < array.length) : (index in array));

+macro HAS_INDEX(array, index, is_array) = ((is_array && %_HasFastPackedElements(%IS_VAR(array)) && (index < array.length)) || (index in array));

# Private names.

macro IS_PRIVATE(sym) = (%SymbolIsPrivate(sym));