content/common/gpu/media/gpu_video_decode_accelerator.cc - Issue 1706023003: Moving the validation of bitstream_buffer into VDA implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.cc

Issue 1706023003: Moving the validation of bitstream_buffer into VDA implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compiling errors on windows Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/gpu_jpeg_decode_accelerator.cc ('k') | content/common/gpu/media/v4l2_jpeg_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/gpu_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.cc b/content/common/gpu/media/gpu_video_decode_accelerator.cc

index d70b5eee80fb77ac2abbdeed01d720a9e4a102ad..a52da9ca0fc32bb741dfd79dd7f3d6c8480eb5fa 100644

--- a/content/common/gpu/media/gpu_video_decode_accelerator.cc

+++ b/content/common/gpu/media/gpu_video_decode_accelerator.cc

@@ -494,21 +494,6 @@ void GpuVideoDecodeAccelerator::OnSetCdm(int cdm_id) {

void GpuVideoDecodeAccelerator::OnDecode(

const AcceleratedVideoDecoderMsg_Decode_Params& params) {

DCHECK(video_decode_accelerator_);

- if (params.bitstream_buffer_id < 0) {

- DLOG(ERROR) << "BitstreamBuffer id " << params.bitstream_buffer_id

- << " out of range";

- if (child_task_runner_->BelongsToCurrentThread()) {

- NotifyError(media::VideoDecodeAccelerator::INVALID_ARGUMENT);

- } else {

- child_task_runner_->PostTask(

- FROM_HERE,

- base::Bind(&GpuVideoDecodeAccelerator::NotifyError,

- base::Unretained(this),

- media::VideoDecodeAccelerator::INVALID_ARGUMENT));

- }

- return;

- }

media::BitstreamBuffer bitstream_buffer(params.bitstream_buffer_id,

params.buffer_handle, params.size,

params.presentation_timestamp);