content/common/gpu/media/gpu_jpeg_decode_accelerator.cc - Issue 1706023003: Moving the validation of bitstream_buffer into VDA implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/gpu_jpeg_decode_accelerator.cc

Issue 1706023003: Moving the validation of bitstream_buffer into VDA implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compiling errors on windows Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/fake_video_decode_accelerator.cc ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/gpu_jpeg_decode_accelerator.cc

diff --git a/content/common/gpu/media/gpu_jpeg_decode_accelerator.cc b/content/common/gpu/media/gpu_jpeg_decode_accelerator.cc

index 4b7b00c138e6b72a064051020aea506b9e435fa6..ba0bd94dfd8a0ed6007cbeaa3bacf47f70df02ca 100644

--- a/content/common/gpu/media/gpu_jpeg_decode_accelerator.cc

+++ b/content/common/gpu/media/gpu_jpeg_decode_accelerator.cc

@@ -41,12 +41,6 @@ void DecodeFinished(scoped_ptr<base::SharedMemory> shm) {

}

bool VerifyDecodeParams(const AcceleratedJpegDecoderMsg_Decode_Params& params) {

- if (params.input_buffer_id < 0) {

- LOG(ERROR) << "BitstreamBuffer id " << params.input_buffer_id

- << " out of range";

- return false;

- }

const int kJpegMaxDimension = UINT16_MAX;

if (params.coded_size.IsEmpty() ||

params.coded_size.width() > kJpegMaxDimension ||

@@ -55,11 +49,6 @@ bool VerifyDecodeParams(const AcceleratedJpegDecoderMsg_Decode_Params& params) {

return false;

}

- if (!base::SharedMemory::IsHandleValid(params.input_buffer_handle)) {

- LOG(ERROR) << "invalid input_buffer_handle";

- return false;

- }

if (!base::SharedMemory::IsHandleValid(params.output_video_frame_handle)) {

LOG(ERROR) << "invalid output_video_frame_handle";

return false;