base/task_scheduler/test_utils.h - Issue 1705943002: TaskScheduler [5/9] Task Tracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/test_utils.h

Issue 1705943002: TaskScheduler [5/9] Task Tracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_3_pq

Patch Set: CR gab #41 (fix a comment) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/test_utils.h

diff --git a/base/task_scheduler/test_utils.h b/base/task_scheduler/test_utils.h

index bafd09aa2a294acd38794af431cbc5901f34ccd0..74eb4b0c6909601386f4bb967bd9f060277b0e9f 100644

--- a/base/task_scheduler/test_utils.h

+++ b/base/task_scheduler/test_utils.h

@@ -13,7 +13,7 @@

#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)

#define EXPECT_DCHECK_DEATH(statement, regex) EXPECT_DEATH(statement, regex)

#else

-#define EXPECT_DCHECK_DEATH(statement, regex)

+#define EXPECT_DCHECK_DEATH(statement, regex) statement

robliao 2016/03/29 00:42:03 Intentional change? Didn't see the comment trigger

fdoray 2016/03/29 11:31:49 Initially it was intentional. But then gab@ said t

robliao 2016/03/29 15:28:10 sgtm. Nit: Keeping this empty should work.

#endif

#endif // BASE_TASK_SCHEDULER_TEST_UTILS_H_

« no previous file with comments | « base/task_scheduler/task_traits.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »