base/task_scheduler/test_utils.h - Issue 1705943002: TaskScheduler [5/9] Task Tracker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/task_scheduler/test_utils.h

Issue 1705943002: TaskScheduler [5/9] Task Tracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_3_pq

Patch Set: CR gab #41 (fix a comment) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/task_scheduler/task_traits.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_TASK_SCHEDULER_TEST_UTILS_H_	5 #ifndef BASE_TASK_SCHEDULER_TEST_UTILS_H_

6 #define BASE_TASK_SCHEDULER_TEST_UTILS_H_	6 #define BASE_TASK_SCHEDULER_TEST_UTILS_H_

7	7

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "build/build_config.h"	9 #include "build/build_config.h"

10 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

11	11

12 // Death tests misbehave on Android.	12 // Death tests misbehave on Android.

13 #if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)	13 #if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)

14 #define EXPECT_DCHECK_DEATH(statement, regex) EXPECT_DEATH(statement, regex)	14 #define EXPECT_DCHECK_DEATH(statement, regex) EXPECT_DEATH(statement, regex)

15 #else	15 #else

16 #define EXPECT_DCHECK_DEATH(statement, regex)	16 #define EXPECT_DCHECK_DEATH(statement, regex) statement
	robliao 2016/03/29 00:42:03 Intentional change? Didn't see the comment trigger Intentional change? Didn't see the comment triggering this. (Delta Added in Patchset 14) Original discussion regarding executing the statement: https://codereview.chromium.org/1706123002/diff/400001/base/task_scheduler/sc... fdoray 2016/03/29 11:31:49 Initially it was intentional. But then gab@ said t Show quoted text On 2016/03/29 00:42:03, robliao wrote: > Intentional change? Didn't see the comment triggering this. (Delta Added in > Patchset 14) > > Original discussion regarding executing the statement: > https://codereview.chromium.org/1706123002/diff/400001/base/task_scheduler/sc... Initially it was intentional. But then gab@ said that he preferred not to execute the statement, so I removed it in the latest patch set. Discussion: https://codereview.chromium.org/1705943002/diff/300001/base/task_scheduler/te... robliao 2016/03/29 15:28:10 sgtm. Nit: Keeping this empty should work. Show quoted text On 2016/03/29 11:31:49, fdoray wrote: > On 2016/03/29 00:42:03, robliao wrote: > > Intentional change? Didn't see the comment triggering this. (Delta Added in > > Patchset 14) > > > > Original discussion regarding executing the statement: > > > https://codereview.chromium.org/1706123002/diff/400001/base/task_scheduler/sc... > > Initially it was intentional. But then gab@ said that he preferred not to > execute the statement, so I removed it in the latest patch set. > > Discussion: > https://codereview.chromium.org/1705943002/diff/300001/base/task_scheduler/te... sgtm. Nit: Keeping this empty should work.
17 #endif	17 #endif

18	18

19 #endif // BASE_TASK_SCHEDULER_TEST_UTILS_H_	19 #endif // BASE_TASK_SCHEDULER_TEST_UTILS_H_

OLD	NEW