Reland of [NaCl SDK] Add initial support for building the SDK with gn

Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset #1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn (patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
>
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
>
> https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/3655/steps/compile/logs/stdio
>
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c ../../native_client/src/trusted/validator/driver/ncval.cc /Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj /Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
>
> (and i'm guessing several more)
>
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
>
> TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
>
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999
Committed: https://crrev.com/92b4d57412e176e3569734b7e33167588b6267db
Cr-Commit-Position: refs/heads/master@{#376080}

[Sam Clegg, 2016-02-17 19:22:09]

Created Reland of [NaCl SDK] Add initial support for building the SDK with gn

[commit-bot: I haz the power, 2016-02-17 19:24:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705923002/1

[Nico, 2016-02-17 19:28:51]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-02-17 19:29:31]

On 2016/02/17 19:24:16, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1705923002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1705923002/1

Can you manually trigger a try run on win_clang_x64_dbg please?

[Sam Clegg, 2016-02-17 19:30:43]

Description was changed from

==========
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset
#1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn
(patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
> 
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> 
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error:
ISO C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
> 
> (and i'm guessing several more)
> 
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
> 
>
TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
> 
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999
==========

to

==========
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset
#1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn
(patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
> 
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> 
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error:
ISO C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
> 
> (and i'm guessing several more)
> 
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
> 
>
TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
> 
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999
==========

[Sam Clegg, 2016-02-17 19:31:15]

Done.  Also added to CQ_INCLUDE_TRYBOTS

[Nico, 2016-02-17 19:33:07]

...actually that's probably going to come back red due to
https://code.google.com/p/chromium/issues/detail?id=587530 at the moment :-/

On Wed, Feb 17, 2016 at 11:31 AM, <sbc@chromium.org> wrote:

> Done.  Also added to CQ_INCLUDE_TRYBOTS
> https://codereview.chromium.org/1705923002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sam Clegg, 2016-02-17 22:27:35]

On 2016/02/17 19:33:07, Nico wrote:
> ...actually that's probably going to come back red due to
> https://code.google.com/p/chromium/issues/detail?id=587530 at the moment :-/

Are you OK with this re-land if/when the bot passes?

> 
> On Wed, Feb 17, 2016 at 11:31 AM, <mailto:sbc@chromium.org> wrote:
> 
> > Done.  Also added to CQ_INCLUDE_TRYBOTS
> > https://codereview.chromium.org/1705923002/
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-02-17 22:38:21]

Yes. If you send a try job now (after
https://chromium.googlesource.com/chromium/src/+/432d2962b984956cfa90653d8d5a...),
the bot even has a chance of coming back green.

[Sam Clegg, 2016-02-17 22:41:24]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-02-17 22:43:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705923002/1

[commit-bot: I haz the power, 2016-02-18 03:28:33]

Description was changed from

==========
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset
#1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn
(patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
> 
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> 
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error:
ISO C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
> 
> (and i'm guessing several more)
> 
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
> 
>
TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
> 
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999
==========

to

==========
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset
#1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn
(patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
> 
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> 
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error:
ISO C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
> 
> (and i'm guessing several more)
> 
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
> 
>
TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
> 
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999
==========

[commit-bot: I haz the power, 2016-02-18 03:28:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-18 03:30:14]

Description was changed from

==========
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset
#1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn
(patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
> 
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> 
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error:
ISO C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
> 
> (and i'm guessing several more)
> 
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
> 
>
TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
> 
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999
==========

to

==========
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset
#1 id:1 of https://codereview.chromium.org/1693213002/ )

Reason for revert:
clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg

Original issue's description:
> Revert of [NaCl SDK] Add initial support for building the SDK with gn
(patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ )
>
> Reason for revert:
> Doesn't build with clang/win and looks nontrivial to fix:
>
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
>
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
> ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error:
ISO C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
>   while ((opt = getopt(argc, argv, "vd")) != -1) {
>                                    ^
>
> (and i'm guessing several more)
>
> Original issue's description:
> > [NaCl SDK] Add initial support for building the SDK with gn
> >
> > build_sdk.py still uses gyp.  I have a followup CL to
> > convert that to gn.
> >
> > BUG=585999
>
>
TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=585999
>
> Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180
> Cr-Commit-Position: refs/heads/master@{#375349}

TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585999

Committed: https://crrev.com/92b4d57412e176e3569734b7e33167588b6267db
Cr-Commit-Position: refs/heads/master@{#376080}
==========

[commit-bot: I haz the power, 2016-02-18 03:30:15]

Patchset 1 (id:??) landed as
https://crrev.com/92b4d57412e176e3569734b7e33167588b6267db
Cr-Commit-Position: refs/heads/master@{#376080}