Fix getopt signature in port_win.h

Fix getopt signature in port_win.h

This was causing a build failure in ncval_new when
using clang on windows:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c ../../native_client/src/trusted/validator/driver/ncval.cc /Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj /Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings]
  while ((opt = getopt(argc, argv, "vd")) != -1) {

BUG=585999
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/d78d8b5237f08d737642aa89b89113dcebf21b14

[Sam Clegg, 2016-02-17 00:02:45]

Description was changed from

==========
Fix getopt signature in port_win.h

This was causing a build failure in ncval_new when
using clang on windows.

BUG=585999
==========

to

==========
Fix getopt signature in port_win.h

This was causing a build failure in ncval_new when
using clang on windows:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error: ISO
C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
  while ((opt = getopt(argc, argv, "vd")) != -1) {

BUG=585999
==========

[Sam Clegg, 2016-02-17 00:02:45]

sbc@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Sam Clegg, 2016-02-17 00:03:13]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 00:03:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706613002/1

[Mark Seaborn, 2016-02-17 00:04:42]

LGTM

[Sam Clegg, 2016-02-17 00:25:16]

The CQ bit was unchecked by sbc@chromium.org

[Sam Clegg, 2016-02-17 00:25:21]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-02-17 00:25:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706613002/1

[commit-bot: I haz the power, 2016-02-17 00:51:36]

Description was changed from

==========
Fix getopt signature in port_win.h

This was causing a build failure in ncval_new when
using clang on windows:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error: ISO
C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
  while ((opt = getopt(argc, argv, "vd")) != -1) {

BUG=585999
==========

to

==========
Fix getopt signature in port_win.h

This was causing a build failure in ncval_new when
using clang on windows:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error: ISO
C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
  while ((opt = getopt(argc, argv, "vd")) != -1) {

BUG=585999

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/d78d8b523...
==========

[commit-bot: I haz the power, 2016-02-17 00:51:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/d78d8b523...