Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 17059005: Make sure ExternalCallbackScope is always created when VM state changes to EXTERNAL (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
Reviewers:
dcarney, alph, Sven Panne, loislo
CC:
v8-dev
Visibility:
Public.

Description

Make sure ExternalCallbackScope is always created when VM state changes to EXTERNAL ExternalCallbackScope is used to let CPU profiler know which API callback is being executed. Whenever such callback is called we should create VMState<ETERNAL> and ExternalCallbackScope. This patch fixes several places where VMState<ETERNAL> went without ExternalCallbackScope. BUG=244580 R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15249

Patch Set 1 #

Patch Set 2 : Removed logging #

Patch Set 3 : Removed obsolete include from objects.cc #

Patch Set 4 : Updated builtins.cc #

Patch Set 5 : more changes, to objects.cc and handles.cc #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -158 lines) Patch
M src/arguments.cc View 1 2 3 6 chunks +12 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 2 chunks +2 lines, -16 lines 0 comments Download
M src/handles.cc View 1 2 3 4 2 chunks +3 lines, -11 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 15 chunks +32 lines, -99 lines 0 comments Download
M src/stub-cache.cc View 1 2 3 4 5 3 chunks +5 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 14 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 6 months ago (2013-06-14 13:02:09 UTC) #1
yurys
This change uses THREADED_PROFILED_TEST macro introduced in https://codereview.chromium.org/17072002/
7 years, 6 months ago (2013-06-14 13:03:01 UTC) #2
dcarney
lgtm I was originally going to remove the various Call functions after cutover from the ...
7 years, 6 months ago (2013-06-14 17:38:42 UTC) #3
Sven Panne
LGTM if neither the v8 perf bots nor the Chrome perf bots show any kind ...
7 years, 6 months ago (2013-06-17 12:02:24 UTC) #4
yurys
7 years, 6 months ago (2013-06-20 14:47:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r15249 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698