Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705853002: NOT FOR REVIEW. ax tree focus with debugging (Closed)

Created:
4 years, 10 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, nektar+watch_chromium.org, eae+blinkwatch, dmazzoni+watch_chromium.org, rwlbuis, extensions-reviews_chromium.org, Matt Giuca, aboxhall, blink-reviews-dom_chromium.org, aboxhall+watch_chromium.org, jam, nona+watch_chromium.org, dglazkov+blink, je_julie, darin-cc_chromium.org, blink-reviews, kalyank, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, tapted, sof, yuzo+watch_chromium.org, dmazzoni, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, plundblad+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nektarios, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR REVIEW. ax tree focus with debugging BUG=

Patch Set 1 #

Patch Set 2 : More logging #

Patch Set 3 : More logs, in GetFocus #

Patch Set 4 : Problem seems to be with return value from automation getFocus #

Patch Set 5 : Rebase #

Patch Set 6 : Fixed crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -337 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 3 4 8 chunks +40 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 2 3 4 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/accessibility/automation_manager_aura.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.h View 2 chunks +8 lines, -40 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 2 3 chunks +111 lines, -16 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 1 2 3 4 5 4 chunks +68 lines, -6 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/sites/desktop.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/actions.js View 1 chunk +0 lines, -12 lines 0 comments Download
A + chrome/test/data/extensions/api_test/automation/tests/desktop/focus_views.html View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/desktop/focus_views.js View 1 chunk +20 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/automation/tests/desktop/focus_web.html View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/desktop/focus_web.js View 1 chunk +54 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/automation/tests/desktop/initial_focus.html View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/desktop/initial_focus.js View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/accessibility_controller.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/test_runner/accessibility_controller.cc View 4 chunks +15 lines, -17 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_ipc_error_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_auralinux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 2 3 4 3 chunks +11 lines, -14 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 2 3 4 11 chunks +29 lines, -57 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 2 3 4 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 1 2 3 4 5 chunks +12 lines, -30 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 5 chunks +3 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 2 3 4 8 chunks +13 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/accessibility_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/test/data/accessibility/event/listbox-focus-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/event/listbox-next-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/event/menulist-next-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/listbox-enabled-states.html View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/listbox-enabled-states-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/selection-states.html View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/selection-states-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AXObjectCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 2 chunks +22 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/resources/calendarPicker.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDocument.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree_data.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_data.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M ui/app_list/views/search_result_actions_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 6 chunks +18 lines, -2 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 4 chunks +54 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Powered by Google App Engine
This is Rietveld 408576698