Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 1705853002: NOT FOR REVIEW. ax tree focus with debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed crash Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
index d02caab647e4d0828ea334aeefb030334eee7e14..73d29f6a1ae820776412366a50188bc00b0e5d26 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
@@ -149,24 +149,38 @@ AXObject* AXObjectCacheImpl::focusedImageMapUIElement(HTMLAreaElement* areaEleme
return 0;
}
-AXObject* AXObjectCacheImpl::focusedUIElementForPage(const Page* page)
+AXObject* AXObjectCacheImpl::focusedObject()
{
- if (!page->settings().accessibilityEnabled())
+ if (!accessibilityEnabled())
return 0;
- // Cross-process accessibility is not yet implemented.
- if (!page->focusController().focusedOrMainFrame()->isLocalFrame())
+ // We don't have to return anything if the focused frame is not local;
+ // the remote frame will have its own AXObjectCacheImpl and the focused
+ // object will be sorted out by the browser process.
+ Page* page = m_document->page();
+ if (!page->focusController().focusedFrame())
return 0;
- // get the focused node in the page
- Document* focusedDocument = toLocalFrame(page->focusController().focusedOrMainFrame())->document();
+ // Get the focused node in the page.
+ Document* focusedDocument = page->focusController().focusedFrame()->document();
Node* focusedNode = focusedDocument->focusedElement();
if (!focusedNode)
focusedNode = focusedDocument;
- if (isHTMLAreaElement(*focusedNode))
+ // If it's an image map, get the focused link within the image map.
+ if (isHTMLAreaElement(focusedNode))
return focusedImageMapUIElement(toHTMLAreaElement(focusedNode));
+ // See if there's a page popup, for example a calendar picker.
+ Element* adjustedFocusedElement = focusedDocument->adjustedFocusedElement();
+ if (isHTMLInputElement(adjustedFocusedElement)) {
+ if (AXObject* axPopup = toHTMLInputElement(adjustedFocusedElement)->popupRootAXObject()) {
+ if (Element* focusedElementInPopup = axPopup->document()->focusedElement())
+ focusedNode = focusedElementInPopup;
+ }
+
+ }
+
AXObject* obj = getOrCreate(focusedNode);
if (!obj)
return 0;
@@ -1120,7 +1134,7 @@ void AXObjectCacheImpl::handleFocusedUIElementChanged(Node* oldFocusedNode, Node
if (!page)
return;
- AXObject* focusedObject = focusedUIElementForPage(page);
+ AXObject* focusedObject = this->focusedObject();
if (!focusedObject)
return;
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h ('k') | third_party/WebKit/Source/web/WebDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698