Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1711983003: Move profile_sync_service_bookmark_unittest to components (Closed)

Created:
4 years, 10 months ago by vabr (Chromium)
Modified:
4 years, 10 months ago
Reviewers:
stanisc, sky, sdefresne
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, sdefresne+watchlist_chromium.org, tim+watch_chromium.org, Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@586642_no_chrome_deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move profile_sync_service_bookmark_unittest to components BUG=586642 Committed: https://crrev.com/511049b23b740db3c6c29a9f5d1bcaecb8824ed1 Cr-Commit-Position: refs/heads/master@{#377242}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Just rebased #

Patch Set 4 : Just rebased #

Patch Set 5 : Just rebased #

Patch Set 6 : Just rebased #

Patch Set 7 : Just rebased #

Patch Set 8 : Just rebased #

Patch Set 9 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2627 lines) Patch
D chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -2627 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M components/browser_sync/browser/BUILD.gn View 4 chunks +6 lines, -0 lines 0 comments Download
M components/browser_sync/browser/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711983003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711983003/80001
4 years, 10 months ago (2016-02-19 22:13:52 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/148105)
4 years, 10 months ago (2016-02-19 22:31:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711983003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711983003/100001
4 years, 10 months ago (2016-02-19 22:58:19 UTC) #6
vabr (Chromium)
Hello sky@ and stanisc@. @sky -- please review adding bookmarks into components/browser_sync/browser/DEPS (note: this is ...
4 years, 10 months ago (2016-02-19 23:01:40 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/148138)
4 years, 10 months ago (2016-02-19 23:15:37 UTC) #10
sky
LGTM
4 years, 10 months ago (2016-02-19 23:26:46 UTC) #11
vabr (Chromium)
Hi stanisc@, a friendly ping. (Adding zea@ in Cc in case he finds time to ...
4 years, 10 months ago (2016-02-23 08:52:40 UTC) #12
stanisc
lgtm
4 years, 10 months ago (2016-02-23 18:30:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711983003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711983003/160001
4 years, 10 months ago (2016-02-24 08:13:48 UTC) #16
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 10 months ago (2016-02-24 08:21:28 UTC) #17
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/511049b23b740db3c6c29a9f5d1bcaecb8824ed1 Cr-Commit-Position: refs/heads/master@{#377242}
4 years, 10 months ago (2016-02-24 08:22:27 UTC) #19
blundell
On 2016/02/24 08:22:27, commit-bot: I haz the power wrote: > Patchset 9 (id:??) landed as ...
4 years, 10 months ago (2016-02-24 10:02:58 UTC) #20
sdefresne
yeah, you rock!
4 years, 10 months ago (2016-02-24 10:24:39 UTC) #22
chromium-reviews
4 years, 10 months ago (2016-02-24 10:27:23 UTC) #23
Message was sent while issue was closed.
Thanks all for your support through reviews and offering interesting tasks.
It's an honour to participate in such a major step as upstreaming the iOS
fork!

On Wed, 24 Feb 2016 at 11:24 <sdefresne@chromium.org> wrote:

> yeah, you rock!
>
> https://codereview.chromium.org/1711983003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698