Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(64)

Issue 17058006: RNG_SystemRNG should fail rather than falling back on rng_systemFromNoise (Closed)

Created:
5 years, 9 months ago by wtc
Modified:
5 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

RNG_SystemRNG should fail rather than falling back on rng_systemFromNoise if it cannot call RtlGenRandom on Windows. Remove the obsolete code for Windows versions older than Windows XP. In unix_rand.c, abort the process under more conditions. R=rsleevi@chromium.org BUG=244661 TEST=none

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use zu to print size_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -92 lines) Patch
M README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M nss/lib/freebl/unix_rand.c View 1 5 chunks +13 lines, -10 lines 0 comments Download
M nss/lib/freebl/win_rand.c View 2 chunks +4 lines, -69 lines 0 comments Download
A patches/nss-rtlgenrandom.patch View 1 chunk +110 lines, -0 lines 0 comments Download
M patches/nss-urandom-abort.patch View 1 3 chunks +37 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
https://codereview.chromium.org/17058006/diff/1/nss/lib/freebl/unix_rand.c File nss/lib/freebl/unix_rand.c (right): https://codereview.chromium.org/17058006/diff/1/nss/lib/freebl/unix_rand.c#newcode888 nss/lib/freebl/unix_rand.c:888: bytes = RNG_FileUpdate("/dev/urandom", SYSTEM_RNG_SEED_COUNT); Here we request SYSTEM_RNG_SEED_COUNT bytes ...
5 years, 9 months ago (2013-06-17 23:04:17 UTC) #1
Ryan Sleevi
lgtm https://codereview.chromium.org/17058006/diff/1/nss/lib/freebl/unix_rand.c File nss/lib/freebl/unix_rand.c (right): https://codereview.chromium.org/17058006/diff/1/nss/lib/freebl/unix_rand.c#newcode929 nss/lib/freebl/unix_rand.c:929: (int)bytes, SYSTEM_RNG_SEED_COUNT); On 2013/06/17 23:04:17, wtc wrote: > ...
5 years, 9 months ago (2013-06-17 23:19:17 UTC) #2
wtc
Good idea! This code is in a Chromium patch, and unix_rand.c is only compiled by ...
5 years, 9 months ago (2013-06-17 23:51:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/17058006/6001
5 years, 9 months ago (2013-06-17 23:53:15 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2013-06-17 23:53:34 UTC) #5
Message was sent while issue was closed.
Change committed as 206843

Powered by Google App Engine
This is Rietveld 408576698