Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1705283002: Add @override when implement missing overrides for fields. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add @override when implement missing overrides for fields. This makes the code generated by DAS closer to the code generated by the IDEA plugin. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/026748533f7960c3e2baff724eee83837718e674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-17 21:04:41 UTC) #1
jwren
On 2016/02/17 21:04:41, scheglov wrote: LGTM
4 years, 10 months ago (2016-02-17 21:05:43 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-17 21:15:41 UTC) #3
scheglov
4 years, 10 months ago (2016-02-17 21:30:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
026748533f7960c3e2baff724eee83837718e674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698