Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 1705283002: Add @override when implement missing overrides for fields. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/fix_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
index 36eb5b94e9b8b3e0ed2b7035cd1883bbf21cdcba..01ddada39915dd611ead32c365ee63f8dd586749 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -1239,6 +1239,7 @@ class FixProcessor {
isFirst = false;
}
// merge getter/setter pairs into fields
+ String prefix = utils.getIndent(1);
for (int i = 0; i < elements.length; i++) {
ExecutableElement element = elements[i];
if (element.kind == ElementKind.GETTER && i + 1 < elements.length) {
@@ -1249,9 +1250,16 @@ class FixProcessor {
elements.removeAt(i);
i--;
numElements--;
- // add field
+ // separator
addEolIfNotFirst();
- sb.append(utils.getIndent(1));
+ // @override
+ {
+ sb.append(prefix);
+ sb.append('@override');
+ sb.append(eol);
+ }
+ // add field
+ sb.append(prefix);
_appendType(sb, element.type.returnType, orVar: true);
sb.append(element.name);
sb.append(';');
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/fix_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698