Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1705203002: Add bilerp filtering. (Closed)

Created:
4 years, 10 months ago by herb_g
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, f(malita)
Base URL:
https://skia.googlesource.com/skia.git@fp-simple-linear-20160217
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 24

Patch Set 2 : Redo bilerp. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -20 lines) Patch
M bench/SkLinearBitmapPipelineBench.cpp View 1 1 chunk +9 lines, -1 line 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.h View 1 3 chunks +22 lines, -2 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 1 9 chunks +134 lines, -14 lines 2 comments Download
M tests/SkLinearBitmapPipelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
herb_g
Here is the next stage of the CL pipeline Roadmap of coming cls. 1) simple ...
4 years, 10 months ago (2016-02-17 19:47:33 UTC) #4
mtklein
https://codereview.chromium.org/1705203002/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1705203002/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode59 src/core/SkLinearBitmapPipeline.cpp:59: class BilerpProcessor : public BilerpProcessorInterface { final (and PointProcessor ...
4 years, 10 months ago (2016-02-17 20:25:10 UTC) #5
herb_g
Redo bilerp.
4 years, 10 months ago (2016-02-17 23:38:13 UTC) #6
herb_g
https://codereview.chromium.org/1705203002/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1705203002/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode59 src/core/SkLinearBitmapPipeline.cpp:59: class BilerpProcessor : public BilerpProcessorInterface { On 2016/02/17 20:25:09, ...
4 years, 10 months ago (2016-02-17 23:40:44 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705203002/20001
4 years, 10 months ago (2016-02-17 23:40:55 UTC) #9
mtklein
lgtm! https://codereview.chromium.org/1705203002/diff/20001/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1705203002/diff/20001/src/core/SkLinearBitmapPipeline.cpp#newcode407 src/core/SkLinearBitmapPipeline.cpp:407: // So x * y is calculated first ...
4 years, 10 months ago (2016-02-17 23:46:56 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 00:03:18 UTC) #12
herb_g
https://codereview.chromium.org/1705203002/diff/20001/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1705203002/diff/20001/src/core/SkLinearBitmapPipeline.cpp#newcode407 src/core/SkLinearBitmapPipeline.cpp:407: // So x * y is calculated first and ...
4 years, 10 months ago (2016-02-18 03:49:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705203002/20001
4 years, 10 months ago (2016-02-18 03:49:26 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 03:50:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c5eddd7d8d67a6e931973a729c5868c155cb751f

Powered by Google App Engine
This is Rietveld 408576698