Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1705173003:
Use std::isnan instead of isnan in global ns (Closed)
DescriptionUse std::isnan instead of isnan in global ns
BUG=
Committed: https://crrev.com/fb40998c019e8f36bdb8e093e4de437ed8af973f
Cr-Commit-Position: refs/heads/master@{#376477}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Description was changed from ========== Use std::isnan instead of isnan in global ns This is a follow-up of https://codereview.chromium.org/1665763002/ and is required for one of our toolchains that lack isnan in the global namespace. BUG= ========== to ========== Use std::isnan instead of isnan in global ns This is a follow-up of https://codereview.chromium.org/1665763002/ and is required for one of our toolchains that lack isnan in the global namespace. BUG= ==========
asaka@opera.com changed reviewers: + dpranke@chromium.org, rbyers@chromium.org
Description was changed from ========== Use std::isnan instead of isnan in global ns This is a follow-up of https://codereview.chromium.org/1665763002/ and is required for one of our toolchains that lack isnan in the global namespace. BUG= ========== to ========== Use std::isnan instead of isnan in global ns BUG= ==========
Hi, This is a follow-up of https://codereview.chromium.org/1665763002/ and is required for one of our toolchains that lack isnan in the global namespace. I'm hoping you will want it in addition! Thanks!
dpranke@chromium.org changed reviewers: + esprehn@chromium.org
this lgtm, but I'm not really an OWNER for Source/platform . esprehn@, want to stamp this?
lgtm
The CQ bit was checked by asaka@opera.com
On 2016/02/18 21:20:34, esprehn wrote: > lgtm Great, thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705173003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705173003/1
Message was sent while issue was closed.
Description was changed from ========== Use std::isnan instead of isnan in global ns BUG= ========== to ========== Use std::isnan instead of isnan in global ns BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use std::isnan instead of isnan in global ns BUG= ========== to ========== Use std::isnan instead of isnan in global ns BUG= Committed: https://crrev.com/fb40998c019e8f36bdb8e093e4de437ed8af973f Cr-Commit-Position: refs/heads/master@{#376477} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fb40998c019e8f36bdb8e093e4de437ed8af973f Cr-Commit-Position: refs/heads/master@{#376477} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
