Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1665763002: Use std::isnan instead of isnan in global ns (Closed)

Created:
4 years, 10 months ago by landell
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, Rick Byers
CC:
chromium-reviews, blink-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org, Navid Zolghadr, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::isnan instead of isnan in global ns BUG= Committed: https://crrev.com/7d38a9a19d8732ef5902e8b4b78d4ae8a3b22f87 Cr-Commit-Position: refs/heads/master@{#373548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/test_runner/event_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
landell
@reviewers: PTAL I have a toolchain that lacks isnan in the global namespace and hope ...
4 years, 10 months ago (2016-02-03 11:34:27 UTC) #3
Rick Byers
Yep, we probably should have used std::isnan here to start - thanks! LGTM
4 years, 10 months ago (2016-02-03 14:36:38 UTC) #5
Dirk Pranke
lgtm also.
4 years, 10 months ago (2016-02-03 16:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665763002/1
4 years, 10 months ago (2016-02-04 14:51:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 16:35:03 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 16:35:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d38a9a19d8732ef5902e8b4b78d4ae8a3b22f87
Cr-Commit-Position: refs/heads/master@{#373548}

Powered by Google App Engine
This is Rietveld 408576698