Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1705133002: Add GrGpu support for Vulkan command buffer flush (Closed)

Created:
4 years, 10 months ago by jvanverth1
Modified:
4 years, 10 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove commented out code #

Patch Set 3 : More morphology fixes #

Patch Set 4 : Merge postFlush and performFlushWorkaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/gpu/GrDrawTarget.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
jvanverth1
Part One of building a complete command buffer per flush
4 years, 10 months ago (2016-02-17 16:51:11 UTC) #3
bsalomon
On 2016/02/17 16:51:11, jvanverth1 wrote: > Part One of building a complete command buffer per ...
4 years, 10 months ago (2016-02-17 17:39:46 UTC) #4
egdaniel
lgtm
4 years, 10 months ago (2016-02-17 17:41:55 UTC) #5
jvanverth1
On 2016/02/17 17:39:46, bsalomon wrote: > On 2016/02/17 16:51:11, jvanverth1 wrote: > > Part One ...
4 years, 10 months ago (2016-02-17 18:00:31 UTC) #6
bsalomon
On 2016/02/17 18:00:31, jvanverth1 wrote: > On 2016/02/17 17:39:46, bsalomon wrote: > > On 2016/02/17 ...
4 years, 10 months ago (2016-02-17 18:08:49 UTC) #7
jvanverth1
On 2016/02/17 18:08:49, bsalomon wrote: > On 2016/02/17 18:00:31, jvanverth1 wrote: > > On 2016/02/17 ...
4 years, 10 months ago (2016-02-17 20:39:50 UTC) #8
bsalomon
lgtm
4 years, 10 months ago (2016-02-17 21:24:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705133002/60001
4 years, 10 months ago (2016-02-17 21:25:28 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:04:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d2d2eb9a01777d8b1653407d8cb04eb21ce30bd2

Powered by Google App Engine
This is Rietveld 408576698