Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1705073003:
Add histograms in Blink for Geolocation request timeouts. (Closed)
|
Created:
4 years, 10 months ago by Michael van Ouwerkerk Modified:
4 years, 10 months ago CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, blink-reviews, asvitkine+watch_chromium.org, timvolodine Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd histograms in Blink for Geolocation request timeouts.
BUG=581816
Committed: https://crrev.com/8604e081efe9aaa08876c792c6cf45a1730a0299
Cr-Commit-Position: refs/heads/master@{#376145}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix typo. #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run
mvanouwerkerk@chromium.org changed reviewers: + isherman@chromium.org, peter@chromium.org
Peter: please take a look from a feature perspective. Ilya: please take a look as histogram owner.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705073003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1705073003/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1705073003/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:15226: + the browser process due to e.g. a slow network or an unresponse system nit: s/unresponse/unresponsive
lgtm
Thanks! https://codereview.chromium.org/1705073003/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1705073003/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:15226: + the browser process due to e.g. a slow network or an unresponse system On 2016/02/17 22:13:42, Ilya Sherman wrote: > nit: s/unresponse/unresponsive Done.
The CQ bit was checked by mvanouwerkerk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1705073003/#ps20001 (title: "Fix typo.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705073003/20001
The CQ bit was unchecked by mvanouwerkerk@chromium.org
Description was changed from ========== Add histograms in Blink for Geolocation request timeouts. ========== to ========== Add histograms in Blink for Geolocation request timeouts. BUG=581816 ==========
The CQ bit was checked by mvanouwerkerk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705073003/20001
Message was sent while issue was closed.
Description was changed from ========== Add histograms in Blink for Geolocation request timeouts. BUG=581816 ========== to ========== Add histograms in Blink for Geolocation request timeouts. BUG=581816 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add histograms in Blink for Geolocation request timeouts. BUG=581816 ========== to ========== Add histograms in Blink for Geolocation request timeouts. BUG=581816 Committed: https://crrev.com/8604e081efe9aaa08876c792c6cf45a1730a0299 Cr-Commit-Position: refs/heads/master@{#376145} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8604e081efe9aaa08876c792c6cf45a1730a0299 Cr-Commit-Position: refs/heads/master@{#376145} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
