Chromium Code Reviews Chromium Code Reviews
Issue 1705073003:
Add histograms in Blink for Geolocation request timeouts. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 5ac20da37ac22b977d4c94f93dba457ffa68c014..9e81aee2f06c1a2eb66a7de2523c99686ddee662 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -15209,6 +15209,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Http response codes in NetworkLocationRequest.</summary> |
| </histogram> |
| +<histogram name="Geolocation.Timeout"> |
| + <owner>mvanouwerkerk@chromium.org</owner> |
| + <summary> |
| + Counts Geolocation request timeout values, bucketing by timeout duration. |
| + This is recorded for all requests upon creation, see |
| + Geolocation.TimeoutExpired for timeouts that actually expired. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Geolocation.TimeoutExpired"> |
| + <owner>mvanouwerkerk@chromium.org</owner> |
| + <summary> |
| + Counts Geolocation request timeout expirations, bucketing by timeout |
| + duration. This means no position was received within the allowed time from |
| + the browser process due to e.g. a slow network or an unresponse system |
|
Ilya Sherman
2016/02/17 22:13:42
nit: s/unresponse/unresponsive
Michael van Ouwerkerk
2016/02/18 10:20:14
Done.
|
| + location provider. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="GoogleNow.Card.Button.Clicked0" enum="GoogleNowCardTypeId"> |
| <owner>robliao@chromium.org</owner> |
| <owner>skare@chromium.org</owner> |
