Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1705053002: clang/win: Fix style errors after https://codereview.chromium.org/1585193002 (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
chongz
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix style errors after https://codereview.chromium.org/1585193002 ..\..\ui/events/keycodes/platform_key_map_win.h(21,1) : error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. class EVENTS_BASE_EXPORT PlatformKeyMap { ^ ..\..\ui\events\keycodes\platform_key_map_win.cc(47,21) : error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] for (int i = 0; i < arraysize(modifier_flags); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ BUG=82385 TBR=chongz Committed: https://chromium.googlesource.com/chromium/src/+/080920dff337ea2e22a33bed25e97d289628bac1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/events/keycodes/platform_key_map_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/keycodes/platform_key_map_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Nico
4 years, 10 months ago (2016-02-17 15:08:43 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/080920dff337ea2e22a33bed25e97d289628bac1 Cr-Commit-Position: refs/heads/master@{#375888}
4 years, 10 months ago (2016-02-17 15:31:44 UTC) #5
Nico
4 years, 10 months ago (2016-02-17 15:32:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
080920dff337ea2e22a33bed25e97d289628bac1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698