Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: ui/events/keycodes/platform_key_map_win.cc

Issue 1705053002: clang/win: Fix style errors after https://codereview.chromium.org/1585193002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/keycodes/platform_key_map_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/platform_key_map_win.cc
diff --git a/ui/events/keycodes/platform_key_map_win.cc b/ui/events/keycodes/platform_key_map_win.cc
index 7fe5cad8cd2218e65c05c53a82b8c13e25d71478..52a44d55838d9c301c8d8caa13ad91f7e55fed1c 100644
--- a/ui/events/keycodes/platform_key_map_win.cc
+++ b/ui/events/keycodes/platform_key_map_win.cc
@@ -44,7 +44,7 @@ const int kModifierFlagsCombinations = (1 << arraysize(modifier_flags)) - 1;
int GetModifierFlags(int combination) {
int flags = EF_NONE;
- for (int i = 0; i < arraysize(modifier_flags); ++i) {
+ for (size_t i = 0; i < arraysize(modifier_flags); ++i) {
if (combination & (1 << i))
flags |= modifier_flags[i];
}
@@ -113,6 +113,8 @@ PlatformKeyMap::PlatformKeyMap(HKL layout) {
UpdateLayout(layout);
}
+PlatformKeyMap::~PlatformKeyMap() {}
+
DomKey PlatformKeyMap::DomCodeAndFlagsToDomKey(DomCode code, int flags) const {
const int flags_to_try[] = {
// Trying to match Firefox's behavior and UIEvents DomKey guidelines.
« no previous file with comments | « ui/events/keycodes/platform_key_map_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698