Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: Source/core/html/canvas/DOMPath.h

Issue 170503002: Implement addPath() method for Path object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/DOMPath.h
diff --git a/Source/core/html/canvas/DOMPath.h b/Source/core/html/canvas/DOMPath.h
index abb01a6fd71745ea202006276c032113dc686b11..fdbe8b60c5866618332b9b060f1676c14fefdc42 100644
--- a/Source/core/html/canvas/DOMPath.h
+++ b/Source/core/html/canvas/DOMPath.h
@@ -30,6 +30,7 @@
#include "bindings/v8/ScriptWrappable.h"
#include "core/html/canvas/CanvasPathMethods.h"
+#include "core/svg/SVGMatrix.h"
#include "core/svg/SVGPathUtilities.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -47,7 +48,20 @@ public:
const Path& path() const { return m_path; }
+ DOMPath(DOMPath* path)
Justin Novosad 2014/02/18 16:09:29 This is weird. This is kind of like a public copy
pals 2014/02/19 11:47:22 Done. Reverted this change.
+ : CanvasPathMethods()
+ {
+ ScriptWrappable::init(this);
+ m_path = path->path();
rwlbuis 2014/02/18 15:59:59 You can put this in the initialization list, it is
pals 2014/02/19 11:47:22 Done.
+ }
+
virtual ~DOMPath() { }
+
+ void addPath(const DOMPath& path, const SVGMatrix& transform)
+ {
+ Path src = path.path();
+ m_path.addPath(src, transform);
+ }
private:
DOMPath() : CanvasPathMethods()
{
@@ -61,13 +75,6 @@ private:
m_path = path;
}
- DOMPath(DOMPath* path)
- : CanvasPathMethods()
- {
- ScriptWrappable::init(this);
- m_path = path->path();
- }
-
DOMPath(const String& pathData)
: CanvasPathMethods()
{

Powered by Google App Engine
This is Rietveld 408576698