Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1704893002: V8 Buildbot: Use v8-side gcmole wrapper. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -43 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/chromium_config.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/testing.py View 1 chunk +3 lines, -14 lines 1 comment Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___gcmole.json View 2 chunks +17 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL
4 years, 10 months ago (2016-02-17 08:41:29 UTC) #3
kjellander_chromium
lgtm https://codereview.chromium.org/1704893002/diff/1/scripts/slave/recipe_modules/v8/testing.py File scripts/slave/recipe_modules/v8/testing.py (left): https://codereview.chromium.org/1704893002/diff/1/scripts/slave/recipe_modules/v8/testing.py#oldcode454 scripts/slave/recipe_modules/v8/testing.py:454: # TODO(machenbach): Make gcmole work with absolute paths. ...
4 years, 10 months ago (2016-02-17 08:48:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704893002/1
4 years, 10 months ago (2016-02-17 09:04:29 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 09:06:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298816

Powered by Google App Engine
This is Rietveld 408576698