 Chromium Code Reviews
 Chromium Code Reviews Issue 1704893002:
  V8 Buildbot: Use v8-side gcmole wrapper.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
    
  
    Issue 1704893002:
  V8 Buildbot: Use v8-side gcmole wrapper.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/tools/build| Index: scripts/slave/recipe_modules/v8/testing.py | 
| diff --git a/scripts/slave/recipe_modules/v8/testing.py b/scripts/slave/recipe_modules/v8/testing.py | 
| index 42bb74febd4b43932d6f31149e65fe4fe6900563..2311ee858bcccdfe4984ca87d094d04a73a11c0f 100644 | 
| --- a/scripts/slave/recipe_modules/v8/testing.py | 
| +++ b/scripts/slave/recipe_modules/v8/testing.py | 
| @@ -451,22 +451,11 @@ class V8DeoptFuzzer(BaseTest): | 
| class V8GCMole(BaseTest): | 
| def run(self, **kwargs): | 
| - # TODO(machenbach): Make gcmole work with absolute paths. Currently, a | 
| 
kjellander_chromium
2016/02/17 08:48:54
Whoa, nice cleanup. 5 levels of parent directory p
 | 
| - # particular clang version is installed on one slave in '/b'. | 
| - env = { | 
| - 'CLANG_BIN': ( | 
| - self.api.path.join('..', '..', '..', '..', '..', 'gcmole', 'bin') | 
| - ), | 
| - 'CLANG_PLUGINS': ( | 
| - self.api.path.join('..', '..', '..', '..', '..', 'gcmole') | 
| - ), | 
| - } | 
| for arch in ['ia32', 'x64', 'arm', 'arm64']: | 
| - self.api.step( | 
| + self.api.python( | 
| 'GCMole %s' % arch, | 
| - ['lua', self.api.path.join('tools', 'gcmole', 'gcmole.lua'), arch], | 
| - cwd=self.api.path['checkout'], | 
| - env=env, | 
| + self.api.path['checkout'].join('tools', 'gcmole', 'run-gcmole.py'), | 
| + [arch], | 
| ) | 
| return TestResults.empty() |