Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.cpp

Issue 1704693002: [SVG 2/5] Do not reload FontResource created by resourceForStaticData() Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_SVGImage_Fix1
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/css/fontfaceset-download-error-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/FontResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/FontResource.cpp b/third_party/WebKit/Source/core/fetch/FontResource.cpp
index 51d6faab1163d3bce06a2fd7e537647fe4ccc365..57e228dd97a6c6f8489302c9241173f3f49f4e65 100644
--- a/third_party/WebKit/Source/core/fetch/FontResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/FontResource.cpp
@@ -194,6 +194,13 @@ void FontResource::allClientsRemoved()
void FontResource::checkNotify()
{
+ // When checkNotify() is called while stillNeedsLoad() is true, for
+ // example when the FontResource is created by
Nate Chapin 2016/03/01 19:17:28 "for example" doesn't seem right here, as this sho
hiroshige 2016/03/01 22:11:51 Done.
+ // ResourceFetcher::preCacheData(), we no longer need loading, so we set
Nate Chapin 2016/03/01 19:17:28 Update preCacheData() to the new name.
hiroshige 2016/03/01 22:11:51 Done.
+ // |m_state| to |LoadInitiated| and make stillNeedsLoad() false here.
+ if (stillNeedsLoad())
+ m_state = LoadInitiated;
Nate Chapin 2016/03/01 19:17:28 Doing this work here is kind of hacky. Is there an
hiroshige 2016/03/01 22:11:52 Not sure > anywhere else. ksakamoto@, do you have
+
m_fontLoadShortLimitTimer.stop();
m_fontLoadLongLimitTimer.stop();
ResourceClientWalker<FontResourceClient> w(m_clients);
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/css/fontfaceset-download-error-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698