[SVG 2/5] Do not reload FontResource created by resourceForStaticData()

third_party/WebKit/Source/core/fetch/FontResource.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile, Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 176 matching lines @@
 }
 
 void FontResource::allClientsRemoved()
 {
     m_fontData.clear();
     Resource::allClientsRemoved();
 }
 
 void FontResource::checkNotify()
 {
+    // When checkNotify() is called while stillNeedsLoad() is true, for
+    // example when the FontResource is created by

[Nate Chapin, 2016/03/01 19:17:28]

"for example" doesn't seem right here, as this should be the only case where
this is true.

[hiroshige, 2016/03/01 22:11:51]

Done.

+    // ResourceFetcher::preCacheData(), we no longer need loading, so we set

[Nate Chapin, 2016/03/01 19:17:28]

Update preCacheData() to the new name.

[hiroshige, 2016/03/01 22:11:51]

Done.

+    // |m_state| to |LoadInitiated| and make stillNeedsLoad() false here.
+    if (stillNeedsLoad())
+        m_state = LoadInitiated;

[Nate Chapin, 2016/03/01 19:17:28]

Doing this work here is kind of hacky. Is there anywhere else we can do it?
Should we at least note that this is kind of hacky? :)

[hiroshige, 2016/03/01 22:11:52]

Not sure > anywhere else.
ksakamoto@, do you have any thoughts?

+
     m_fontLoadShortLimitTimer.stop();
     m_fontLoadLongLimitTimer.stop();
     ResourceClientWalker<FontResourceClient> w(m_clients);
     while (FontResourceClient* c = w.next())
         c->fontLoaded(this);
 }
 
 } // namespace blink