Replace NativeImageSkia usage with SkBitmap in ImageFrame

Replace NativeImageSkia usage with SkBitmap in ImageFrame

Make ImageFrame store an SkBitmap directly instead of indirectly via
NativeImageSkia.
The direct effect is less indirections in ImageFrame, but this allows
making NativeImageSkia more immutable-looking since the SkBitmap&
accessor and setDataComplete() method can be removed.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170553

[Stephen White, 2014-03-28 17:18:30]

LGTM, but I'd like pkasting or hclam to take a look.

One service NativeImageSkia provides over SkBitmap is cacheing of high-quality
resized images. I assume that ImageFrame and the decoders don't make use of that
functionality, but I'd like someone to verify that (just in case the tests
don't).

[Peter Kasting, 2014-03-28 17:47:04]

I don't believe we use that cache-resized-images functionality.  hclam would
know better than I would.

[Alpha Left Google, 2014-03-31 14:24:59]

On 2014/03/28 17:47:04, Peter Kasting wrote:
> I don't believe we use that cache-resized-images functionality.  hclam would
> know better than I would.

This looks correct to me. Caching of resampled images in NativeImageSkia is used
when drawn only. lgtm.

[jochen (gone - plz use gerrit), 2014-04-01 11:34:57]

lgtm

[fs, 2014-04-01 11:41:57]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-01 11:42:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/170463002/60001

[commit-bot: I haz the power, 2014-04-01 11:52:36]

Change committed as 170553