Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704353002: [runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray BUG= Committed: https://crrev.com/9bebb028a0ac258c66d9b4bf5c99d630e08020a6 Cr-Commit-Position: refs/heads/master@{#34118}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Add comment #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -136 lines) Patch
M src/accessors.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/access-info.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 2 chunks +10 lines, -2 lines 0 comments Download
M src/factory.cc View 1 2 3 4 3 chunks +3 lines, -13 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +15 lines, -8 lines 0 comments Download
M src/json-parser.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/lookup.h View 5 chunks +4 lines, -5 lines 0 comments Download
M src/lookup.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M src/objects.cc View 6 chunks +2 lines, -11 lines 0 comments Download
M src/objects-inl.h View 1 2 3 9 chunks +38 lines, -41 lines 0 comments Download
M src/property.h View 2 chunks +11 lines, -18 lines 0 comments Download
M src/transitions.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
jkummerow: ptal mstarzinger: ptal at compiler & heap
4 years, 10 months ago (2016-02-18 12:40:31 UTC) #2
Michael Starzinger
LGTM on compiler and heap, didn't look at the rest. https://codereview.chromium.org/1704353002/diff/20001/src/compiler/access-info.cc File src/compiler/access-info.cc (right): https://codereview.chromium.org/1704353002/diff/20001/src/compiler/access-info.cc#newcode234 ...
4 years, 10 months ago (2016-02-18 12:49:56 UTC) #3
Jakob Kummerow
LGTM. https://codereview.chromium.org/1704353002/diff/40001/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/1704353002/diff/40001/src/factory.cc#newcode2232 src/factory.cc:2232: // Make sure the string cached in the ...
4 years, 10 months ago (2016-02-18 13:40:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704353002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704353002/80001
4 years, 10 months ago (2016-02-18 13:59:33 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-18 14:33:39 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/9bebb028a0ac258c66d9b4bf5c99d630e08020a6 Cr-Commit-Position: refs/heads/master@{#34118}
4 years, 10 months ago (2016-02-18 14:33:53 UTC) #10
Benedikt Meurer
4 years, 10 months ago (2016-02-19 04:58:24 UTC) #12
Message was sent while issue was closed. 
Looks like Splay doesn't like this change.

Powered by Google App Engine
This is Rietveld 408576698