test/cctest/heap/test-heap.cc - Issue 1704353002: [runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/heap/test-heap.cc

Issue 1704353002: [runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/heap/test-heap.cc

diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc

index 691f0b0cd73774bb7dc3ea9a7e1049d290255472..88aee8adf89e4794ded2445a3261d83a01ca650f 100644

--- a/test/cctest/heap/test-heap.cc

+++ b/test/cctest/heap/test-heap.cc

@@ -5703,9 +5703,10 @@ TEST(Regress388880) {

Heap* heap = isolate->heap();

Handle<Map> map1 = Map::Create(isolate, 1);

+ Handle<String> name = factory->NewStringFromStaticChars("foo");

+ name = factory->InternalizeString(name);

Handle<Map> map2 =

- Map::CopyWithField(map1, factory->NewStringFromStaticChars("foo"),

- FieldType::Any(isolate), NONE,

+ Map::CopyWithField(map1, name, FieldType::Any(isolate), NONE,

Representation::Tagged(), OMIT_TRANSITION)

.ToHandleChecked();

« no previous file with comments | « src/transitions-inl.h ('k') | no next file » | no next file with comments »