Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1704313003: X87: disable the regress-crbug-242924 test case for x87. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: disable the regress-crbug-242924 test case for x87. The reason: Similar to the CL 31552 (https://codereview.chromium.org/1419573007). The CL 33972 (https://codereview.chromium.org/1698783002) optimized some JS function in regress-crbug-242924 test case by TurboFan compiler. But it will hit the known issue that X87 will change a sNaN to qNaN by default. And then it will fail when comparing the source (sNaN) Hole NaN and the result (qNaN) which was expected to be a (sNaN) Hole NaN too. BUG= Committed: https://crrev.com/3e36babe38814844c1a10302772ebdb31e0d2250 Cr-Commit-Position: refs/heads/master@{#34104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-18 08:29:06 UTC) #2
Benedikt Meurer
LGTM
4 years, 10 months ago (2016-02-18 09:05:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704313003/1
4 years, 10 months ago (2016-02-18 09:07:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:37:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:37:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e36babe38814844c1a10302772ebdb31e0d2250
Cr-Commit-Position: refs/heads/master@{#34104}

Powered by Google App Engine
This is Rietveld 408576698