Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1698783002: [turbofan] Lower object and array literals in JSCreateLowering. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower object and array literals in JSCreateLowering. This adds initial support for inline allocation of object and array literals to the JSCreateLowering pass. It's basically identical to what Crankshaft does. This also unstages the TurboFan escape analysis, as the lowering seems to trigger a bunch of bugs in it; those bugs will be fixed separately, and we will re-enable escape analysis afterwards. R=jarin@chromium.org Committed: https://crrev.com/052dc9e0193bfe43c961b405d7855ff78ce13fa1 Cr-Commit-Position: refs/heads/master@{#33972}

Patch Set 1 #

Patch Set 2 : Work-around for hole NaN on x86. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -5 lines) Patch
M src/compiler/js-create-lowering.h View 5 chunks +21 lines, -2 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 6 chunks +321 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-15 05:26:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698783002/1
4 years, 10 months ago (2016-02-15 05:27:00 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/2778) v8_win_rel_ng_triggered on ...
4 years, 10 months ago (2016-02-15 05:44:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698783002/20001
4 years, 10 months ago (2016-02-15 05:55:41 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 06:21:52 UTC) #9
Jarin
lgtm
4 years, 10 months ago (2016-02-15 06:29:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698783002/20001
4 years, 10 months ago (2016-02-15 06:41:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 06:42:45 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 06:43:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/052dc9e0193bfe43c961b405d7855ff78ce13fa1
Cr-Commit-Position: refs/heads/master@{#33972}

Powered by Google App Engine
This is Rietveld 408576698