Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170423003: Revert "Support Gerrit snapshot versions" (Closed)

Created:
6 years, 10 months ago by davidjames
Modified:
6 years, 10 months ago
Reviewers:
cmp, szager1, David James
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Revert "Support Gerrit snapshot versions" This reverts commit cdd969094616ce96d914d692e0d953e1d6c057dc, which broke gerrit_unittest.py within the chroot, which has Java 6. Original-Review URL: https://codereview.chromium.org/164023005 TBR=szager BUG=344786 TEST=Run the unit tests before and after. Confirm this CL fixes them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=251976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M testing_support/gerrit-init.sh View 1 chunk +14 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
David James
6 years, 10 months ago (2014-02-19 06:39:19 UTC) #1
David James
The CQ bit was checked by davidjames@google.com
6 years, 10 months ago (2014-02-19 06:39:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 06:39:28 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-19 06:39:29 UTC) #4
szager1
lgtm
6 years, 10 months ago (2014-02-19 06:40:52 UTC) #5
David James
The CQ bit was checked by davidjames@google.com
6 years, 10 months ago (2014-02-19 06:41:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidjames@chromium.org/170423003/1
6 years, 10 months ago (2014-02-19 06:41:09 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:42:56 UTC) #8
Message was sent while issue was closed. 
Change committed as 251976

Powered by Google App Engine
This is Rietveld 408576698