Support Gerrit snapshot versions

Support Gerrit snapshot versions

These may be named git-snapshot-VERSION.war, where VERSION is the long
format defined in git-describe(1). In particular, this may include a
number of commits after the given tag name; treat more commits since
the tag as a higher version number. This is arguably not always
strictly correct due to non-linear history, but the maintainers expect
the total number of such snapshot versions to be low, and can remove
old snapshot versions that don't sort correctly.

Slightly de-obfuscate some of the variable names and logic while we're
at it.

R=szager@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=251888

[szager, 2014-02-18 23:37:05]

https://codereview.chromium.org/164023005/diff/1/testing_support/gerrit-init.sh
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/164023005/diff/1/testing_support/gerrit-init....
testing_support/gerrit-init.sh:80: gerrit_re =
re.compile('gerrit(?:-full|-snapshot)?-([0-9.]+)(-rc[0-9]+)?'
Can you give me an example of a string that would match this?  I tried matching
some of the existing entries against this regex, and I can't get one to match.

[szager, 2014-02-18 23:47:20]

lgtm

https://codereview.chromium.org/164023005/diff/1/testing_support/gerrit-init.sh
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/164023005/diff/1/testing_support/gerrit-init....
testing_support/gerrit-init.sh:80: gerrit_re =
re.compile('gerrit(?:-full|-snapshot)?-([0-9.]+)(-rc[0-9]+)?'
On 2014/02/18 23:37:05, szager wrote:
> Can you give me an example of a string that would match this?  I tried
matching
> some of the existing entries against this regex, and I can't get one to match.

Never mind; cut-paste error.

[szager, 2014-02-18 23:48:26]

The CQ bit was checked by szager@google.com

[commit-bot: I haz the power, 2014-02-18 23:48:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dborowitz@google.com/164023005/1

[commit-bot: I haz the power, 2014-02-18 23:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-18 23:50:16]

Presubmit check for 164023005-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/testing_support/gerrit-init.sh

Presubmit checks took 99.6s to calculate.

[szager1, 2014-02-19 00:03:53]

lgtm

lgtm

[szager1, 2014-02-19 00:04:02]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-02-19 00:04:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dborowitz@google.com/164023005/1

[commit-bot: I haz the power, 2014-02-19 00:05:47]

Change committed as 251888