Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1704223002: Remove strong mode support from Scope and Variable (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove strong mode support from Scope and Variable This frees up one bit in FunctionKind, which I plan to make slightly more syntactic info about functions available in SharedFunctionInfo (needed for ES2015 Function.name support). BUG=v8:3956, v8:4760 LOG=n Committed: https://crrev.com/63efda35b3e26c1879fb8e1cc079eed455b3903e Cr-Commit-Position: refs/heads/master@{#34125}

Patch Set 1 #

Patch Set 2 : Remove test-parsing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -998 lines) Patch
M src/api.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/ast/ast.h View 2 chunks +6 lines, -21 lines 0 comments Download
M src/ast/scopeinfo.cc View 10 chunks +2 lines, -74 lines 0 comments Download
M src/ast/scopes.h View 6 chunks +5 lines, -33 lines 0 comments Download
M src/ast/scopes.cc View 14 chunks +12 lines, -154 lines 0 comments Download
M src/ast/variables.h View 6 chunks +1 line, -55 lines 0 comments Download
M src/ast/variables.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/globals.h View 3 chunks +1 line, -21 lines 0 comments Download
M src/messages.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.h View 6 chunks +4 lines, -18 lines 0 comments Download
M src/parsing/parser.cc View 4 chunks +6 lines, -45 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +3 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +0 lines, -55 lines 0 comments Download
D test/mjsunit/strong/declaration-after-use.js View 1 chunk +0 lines, -255 lines 0 comments Download
D test/mjsunit/strong/mutually-recursive-classes.js View 1 chunk +0 lines, -229 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 10 months ago (2016-02-17 23:37:12 UTC) #3
rossberg
lgtm
4 years, 10 months ago (2016-02-18 10:34:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704223002/20001
4 years, 10 months ago (2016-02-18 17:17:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 17:19:44 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 17:20:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63efda35b3e26c1879fb8e1cc079eed455b3903e
Cr-Commit-Position: refs/heads/master@{#34125}

Powered by Google App Engine
This is Rietveld 408576698