Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/globals.h

Issue 1704223002: Remove strong mode support from Scope and Variable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove test-parsing test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/variables.cc ('k') | src/messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index d1cae952a827175c5256da59362eaae411af9482..75006ae0ecfdd459c89d9717c5edb0e469e49b38 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -984,15 +984,10 @@ enum FunctionKind {
kDefaultConstructor = 1 << 4,
kSubclassConstructor = 1 << 5,
kBaseConstructor = 1 << 6,
- kInObjectLiteral = 1 << 7,
kDefaultBaseConstructor = kDefaultConstructor | kBaseConstructor,
kDefaultSubclassConstructor = kDefaultConstructor | kSubclassConstructor,
kClassConstructor =
kBaseConstructor | kSubclassConstructor | kDefaultConstructor,
- kConciseMethodInObjectLiteral = kConciseMethod | kInObjectLiteral,
- kConciseGeneratorMethodInObjectLiteral =
- kConciseGeneratorMethod | kInObjectLiteral,
- kAccessorFunctionInObjectLiteral = kAccessorFunction | kInObjectLiteral,
};
@@ -1006,10 +1001,7 @@ inline bool IsValidFunctionKind(FunctionKind kind) {
kind == FunctionKind::kDefaultBaseConstructor ||
kind == FunctionKind::kDefaultSubclassConstructor ||
kind == FunctionKind::kBaseConstructor ||
- kind == FunctionKind::kSubclassConstructor ||
- kind == FunctionKind::kConciseMethodInObjectLiteral ||
- kind == FunctionKind::kConciseGeneratorMethodInObjectLiteral ||
- kind == FunctionKind::kAccessorFunctionInObjectLiteral;
+ kind == FunctionKind::kSubclassConstructor;
}
@@ -1071,18 +1063,6 @@ inline bool IsConstructable(FunctionKind kind, LanguageMode mode) {
}
-inline bool IsInObjectLiteral(FunctionKind kind) {
- DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kInObjectLiteral;
-}
-
-
-inline FunctionKind WithObjectLiteralBit(FunctionKind kind) {
- kind = static_cast<FunctionKind>(kind | FunctionKind::kInObjectLiteral);
- DCHECK(IsValidFunctionKind(kind));
- return kind;
-}
-
inline uint32_t ObjectHash(Address address) {
// All objects are at least pointer aligned, so we can remove the trailing
// zeros.
« no previous file with comments | « src/ast/variables.cc ('k') | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698