Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1703983002: Delete unnecessary BASE_STATE_DIRECTORY_LOCK in TabPersistentStore (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, Peter Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unnecessary BASE_STATE_DIRECTORY_LOCK in TabPersistentStore BUG=None Committed: https://crrev.com/5cabd4e97172d9e015e1e504fa0712c4878bc8c1 Cr-Commit-Position: refs/heads/master@{#375924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 2 chunks +1 line, -6 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Dependent Patchsets:

Issue 1708763003 Patch 1

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703983002/1
4 years, 10 months ago (2016-02-17 16:24:20 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 17:04:47 UTC) #4
agrieve
🎧
4 years, 10 months ago (2016-02-17 17:55:09 UTC) #6
gone
lgtm if findbugs is cool with it.
4 years, 10 months ago (2016-02-17 18:00:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703983002/1
4 years, 10 months ago (2016-02-17 18:11:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 18:18:37 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 18:19:46 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5cabd4e97172d9e015e1e504fa0712c4878bc8c1
Cr-Commit-Position: refs/heads/master@{#375924}

Powered by Google App Engine
This is Rietveld 408576698