Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3629)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java

Issue 1703983002: Delete unnecessary BASE_STATE_DIRECTORY_LOCK in TabPersistentStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
index 439d9f12aad227afea41a9a80d291ff2a0276820..fd870da029d87051ff1206444a8f04a97e6bb582 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
@@ -63,9 +63,6 @@ public class TabPersistentStore extends TabPersister {
/** Prevents two copies of the Migration task from being created. */
private static final Object MIGRATION_LOCK = new Object();
- /** Prevents race conditions when setting the sBaseStateDirectory. */
- private static final Object BASE_STATE_DIRECTORY_LOCK = new Object();
-
/** Prevents two TabPersistentStores from saving the same file simultaneously. */
private static final Object SAVE_LIST_LOCK = new Object();
@@ -205,9 +202,7 @@ public class TabPersistentStore extends TabPersister {
*/
@VisibleForTesting
public static void setBaseStateDirectory(File directory) {
- synchronized (BASE_STATE_DIRECTORY_LOCK) {
- sBaseStateDirectory = directory;
- }
+ sBaseStateDirectory = directory;
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698