Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1703863003:
Created separate shards for suspicious testcases. (Closed)
|
Created:
4 years, 10 months ago by BigBossZhiling Modified:
4 years, 8 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCreated separate shards for suspicious testcases.
In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase.
BUG=581086
Committed: https://crrev.com/09361b7a2000298da27d831553547eed54a6f894
Cr-Commit-Position: refs/heads/master@{#379987}
Patch Set 1 #
Total comments: 2
Patch Set 2 : parse output to detect dcheck and null pointer #Patch Set 3 : fixes #
Total comments: 11
Patch Set 4 : Fixes #Patch Set 5 : fixes #
Total comments: 9
Patch Set 6 : fixes #
Total comments: 2
Patch Set 7 : fixes! Took away the exception. #Patch Set 8 : UI Automator test case for chrome://crash. #
Messages
Total messages: 22 (7 generated)
Description was changed from ========== Created separate shards for suspicious testcases. In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase. BUG=581086 ========== to ========== Created separate shards for suspicious testcases. In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase. BUG=581086 ==========
hzl@google.com changed reviewers: + jbudorick@chromium.org
https://codereview.chromium.org/1703863003/diff/1/build/android/pylib/local/d... File build/android/pylib/local/device/local_device_test_run.py (right): https://codereview.chromium.org/1703863003/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_test_run.py:79: def find_suspects(unfinished_tests, shards): This is gtest-specific and should be handled as such. https://codereview.chromium.org/1703863003/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_test_run.py:139: shards = self._CreateShards(tests, suspects) Shard creation is going to have to be result-aware, but this isn't exactly what I had in mind. What if we actually used the existing results in shard creation & better detected crashed tests? (also, as is, this call will break instrumentation tests)
hzl@hzl0:/usr/local/google/code/clankium4/src$ build/android/test_runner.py gtest -s android_webview_unittests | tee ~/crash_result W 0.041s Main No isolate file provided. No data deps will be pushed. C 23.918s Main ******************************************************************************** C 23.918s Main Detailed Logs C 23.918s Main ******************************************************************************** C 23.919s Main ******************************************************************************** C 23.919s Main Summary C 23.919s Main ******************************************************************************** C 23.920s Main [==========] 90 tests ran. C 23.920s Main [ PASSED ] 88 tests. C 23.920s Main [ FAILED ] 2 tests, listed below: C 23.920s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ReadWithNullStream (UNKNOWN) C 23.920s Main [ FAILED ] AwMediaUrlInterceptorTest.TestInterceptValidAssetUrl (UNKNOWN) C 23.920s Main C 23.920s Main 2 FAILED TESTS C 23.920s Main ********************************************************************************
hzl@google.com changed reviewers: + mikecase@chromium.org
https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/gte... File build/android/pylib/gtest/gtest_test_instance.py (right): https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:347: crash_happened = re.search(r'FAILURES!!! Tests run: \d+, Failures: \d+,' \ all of the regexes in here should compiled into module-private constants, e.g. this should be _TEST_ERROR_RE = re.compile(r'FAILURES!!! ...') ... def GetCrashedTestCase(self, output): crash_happened = _TEST_ERROR_RE.search(output[-1]) https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:352: #Crashes that will cause output like DCHECK(false). nit: # Crashes ... https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:353: has_crash = re.search(r'\[ERROR:.*?\] Currently running: ', output[-3]) magical -3 https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:360: run_info = re.search(r'(?<=\[ RUN \] ).*', output[index-1]) Why is this doing a lookbehind if you're matching on .*? (I had to look up the regex syntax here.) What exactly do you intend to match? https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:232: self.suspects = set() suspects here should probably be _suspects https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:288: # each suspects, so that other tests can be run. nit: suspect https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:293: shards += [[suspect] for suspect in self.suspects if suspect in tests] will suspect ever not be in tests...? https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:353: results = self._test_instance.ParseGTestOutput(output) What if we did crash parsing in ParseGTestOutput and extracted suspects from results as any test case with result type CRASH?
hzl@hzl0:/usr/local/google/code/clankium4/src$ build/android/test_runner.py gtest -s android_webview_unittests W 0.041s Main No isolate file provided. No data deps will be pushed. C 24.865s Main ******************************************************************************** C 24.865s Main Detailed Logs C 24.865s Main ******************************************************************************** C 24.865s Main ******************************************************************************** C 24.865s Main Summary C 24.865s Main ******************************************************************************** C 24.866s Main [==========] 90 tests ran. C 24.866s Main [ PASSED ] 88 tests. C 24.866s Main [ FAILED ] 2 tests, listed below: C 24.866s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ReadWithNullStream (CRASHED) C 24.866s Main [ FAILED ] AwMediaUrlInterceptorTest.TestInterceptValidAssetUrl (CRASHED) C 24.866s Main C 24.866s Main 2 FAILED TESTS C 24.867s Main ******************************************************************************** https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:232: self.suspects = set() On 2016/02/27 00:31:38, jbudorick wrote: > suspects here should probably be _suspects Done. https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:288: # each suspects, so that other tests can be run. On 2016/02/27 00:31:38, jbudorick wrote: > nit: suspect Done. https://codereview.chromium.org/1703863003/diff/40001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:293: shards += [[suspect] for suspect in self.suspects if suspect in tests] On 2016/02/27 00:31:38, jbudorick wrote: > will suspect ever not be in tests...? I am not sure. Is there a case where multiple test suites will be run? Suspects of one test suite should not appear in the test run of another test suite though.
https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/gte... File build/android/pylib/gtest/gtest_test_instance.py (right): https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:210: self._TEST_ERROR_RE = re.compile(r'FAILURES!!! Tests run: \d+,' not class-scope constants, top level module-scope constants. https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:359: has_crash = self._TEST_CURRENTLY_RUNNING_RE.search(output[-3]) Can we either document this -3 or check for _TEST_CURRENTLY_RUNNING_RE matches in a more robust way? https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:364: index = -1 if not self._TEST_CRASH_TAG in output \ Do we need to check all of output for _TEST_CRASH_TAG, or will is always appear in the last line if it appears at all? also, nit: use parentheses to wrap multi-line statements rather than continuing lines with \ https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:367: run_info = self._TEST_RUN_RE.search(output[index-1]) I think this should scan up until it finds a match rather than solely checking index-1 https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/gte... build/android/pylib/gtest/gtest_test_instance.py:407: results.append(base_test_result.BaseTestResult(crashed_test_case, \ nit: again, no \ https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/loc... File build/android/pylib/local/device/local_device_gtest_run.py (left): https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:338: # Parse the output. ? https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/loc... File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:19: from pylib.base import base_test_result nit: alphabetize https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:351: nit: don't add this line https://codereview.chromium.org/1703863003/diff/80001/build/android/pylib/loc... build/android/pylib/local/device/local_device_gtest_run.py:355: for result in results: These three lines can be: self._crashes.update(r for r in results if r.GetType() == base_test_result.ResultType.CRASH)
hzl@hzl0:/usr/local/google/code/clankium4/src$ build/android/test_runner.py gtest -s android_webview_unittests W 0.042s Main No isolate file provided. No data deps will be pushed. C 24.198s Main ******************************************************************************** C 24.199s Main Detailed Logs C 24.199s Main ******************************************************************************** C 24.199s Main [CRASH] AndroidStreamReaderURLRequestJobTest.ReadWithNullStream: C 24.199s Main [ RUN ] AndroidStreamReaderURLRequestJobTest.ReadWithNullStream C 24.199s Main [FATAL:android_stream_reader_url_request_job_unittest.cc(277)] Check failed: false. C 24.199s Main #00 0x45274cd9 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x00472cd9 C 24.199s Main #01 0x451377b7 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x003357b7 C 24.199s Main #02 0x451f0307 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x003ee307 C 24.199s Main #03 0x451f0439 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x003ee439 C 24.199s Main #04 0x451f04c1 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x003ee4c1 C 24.200s Main #05 0x451f2dcd /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x003f0dcd C 24.200s Main #06 0x451ec90f /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x003ea90f C 24.200s Main #07 0x4516e0a7 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x0036c0a7 C 24.200s Main #08 0x45127a37 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x00325a37 C 24.200s Main #09 0x474e9393 /data/app/org.chromium.native_test-2/lib/arm/libandroid_webview_unittests.so+0x026e7393 C 24.200s Main #10 0x49d1886f /data/dalvik-cache/arm/data@app@org.chromium.native_test-2@base.apk@classes.d... C 24.200s Main C 24.200s Main [ERROR:test_suite.cc(258)] Currently running: AndroidStreamReaderURLRequestJobTest.ReadWithNullStream C 24.200s Main [CRASH] AwMediaUrlInterceptorTest.TestInterceptValidAssetUrl: C 24.200s Main [ RUN ] AwMediaUrlInterceptorTest.TestInterceptValidAssetUrl C 24.200s Main [ CRASHED ] C 24.200s Main ******************************************************************************** C 24.200s Main Summary C 24.200s Main ******************************************************************************** C 24.201s Main [==========] 90 tests ran. C 24.201s Main [ PASSED ] 88 tests. C 24.201s Main [ FAILED ] 2 tests, listed below: C 24.201s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ReadWithNullStream (CRASHED) C 24.201s Main [ FAILED ] AwMediaUrlInterceptorTest.TestInterceptValidAssetUrl (CRASHED) C 24.201s Main C 24.201s Main 2 FAILED TESTS C 24.201s Main ********************************************************************************
Yay! lgtm w/ nits https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... File build/android/pylib/gtest/gtest_test_instance.py (right): https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... build/android/pylib/gtest/gtest_test_instance.py:214: nit: remove these two blank lines https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... build/android/pylib/gtest/gtest_test_instance.py:382: # Needs another matcher here to match crashess, like those of DCHECK. nit: s/crashess/crashes/
On 2016/03/01 23:19:15, jbudorick wrote: > Yay! lgtm w/ nits (but back out the android_webview changes before landing, obviously) > > https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... > File build/android/pylib/gtest/gtest_test_instance.py (right): > > https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... > build/android/pylib/gtest/gtest_test_instance.py:214: > nit: remove these two blank lines > > https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... > build/android/pylib/gtest/gtest_test_instance.py:382: # Needs another matcher > here to match crashess, like those of DCHECK. > nit: s/crashess/crashes/
FYI, without the changes, but with the exception thrown in the apk, it looked like the following. hzl@hzl0:/usr/local/google/code/clankium4/src$ build/android/test_runner.py gtest -s android_webview_unittests W 0.041s Main No isolate file provided. No data deps will be pushed. C 13.914s Main ******************************************************************************** C 13.914s Main Detailed Logs C 13.914s Main ******************************************************************************** C 13.915s Main ******************************************************************************** C 13.915s Main Summary C 13.915s Main ******************************************************************************** C 13.916s Main [==========] 90 tests ran. C 13.916s Main [ PASSED ] 9 tests. C 13.916s Main [ FAILED ] 81 tests, listed below: C 13.917s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.DeleteJobMidWayRead (UNKNOWN) C 13.917s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.DeleteJobMidWaySeek (UNKNOWN) C 13.917s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ModifyHeadersAndStatus (UNKNOWN) C 13.917s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ReadPartOfStream (UNKNOWN) C 13.917s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ReadStreamWithMoreAvailableThanActual (UNKNOWN) C 13.917s Main [ FAILED ] AndroidStreamReaderURLRequestJobTest.ReadWithNullStream (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestEmptyDataURLSerialization (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestHeaderSerialization (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestHugeDataURLSerialization (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestLegacyNavigationEntrySerialization (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestLegacyVersionHeaderSerialization (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestNavigationEntrySerialization (UNKNOWN) C 13.917s Main [ FAILED ] AndroidWebViewStateSerializerTest.TestUnsupportedVersionHeaderSerialization (UNKNOWN) C 13.917s Main [ FAILED ] AwContentsClientBridgeTest.TestClientCertKeyTypesCorrectlyEncoded (UNKNOWN) C 13.917s Main [ FAILED ] AwContentsClientBridgeTest.TestProvideClientCertificateResponseCallsCallbackOnNullChain (UNKNOWN) C 13.917s Main [ FAILED ] AwContentsClientBridgeTest.TestProvideClientCertificateResponseCallsCallbackOnNullKey (UNKNOWN) C 13.917s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.CaseInsensitiveDomainTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.CookieOrdering (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.DeleteCanonicalCookieAsync (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.DeleteSessionCookie (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.DomainTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.DomainWithTrailingDotTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.DomainWithoutLeadingDotParentDomain (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.DomainWithoutLeadingDotSameDomain (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.EmptyExpires (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.GetAllCookiesAsync (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.HttpOnlyTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.InvalidDomainSameDomainAndRegistry (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.InvalidDomainTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.InvalidScheme (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.InvalidScheme_Read (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.NetUtilCookieTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.OverwritePersistentCookie (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.PathTest (UNKNOWN) C 13.918s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.SetCookieWithDetailsAsync (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestCookieDeletion (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestDeleteAll (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestDeleteAllCreatedBetween (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestDeleteAllCreatedBetweenForHost (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestHostEndsWithDot (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestIpAddress (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestIpAddressNoDomainCookies (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestSecure (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestSettingCookiesOnUnknownTLD (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestSettingCookiesWithHostDomainOnUnknownTLD (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestSubdomainSettingCookiesOnKnownDottedTLD (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestSubdomainSettingCookiesOnKnownTLD (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestSubdomainSettingCookiesOnUnknownTLD (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestTLD (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.TestTLDWithTerminalDot (UNKNOWN) C 13.919s Main [ FAILED ] AwCookieStoreWrapper/CookieStoreTest/0.ValidSubdomainTest (UNKNOWN) C 13.919s Main [ FAILED ] AwMediaUrlInterceptorTest.TestInterceptInvalidAssetUrl (UNKNOWN) C 13.919s Main [ FAILED ] AwMediaUrlInterceptorTest.TestInterceptNonAssetUrl (UNKNOWN) C 13.920s Main [ FAILED ] AwMediaUrlInterceptorTest.TestInterceptValidAssetUrl (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.BytesAvailableFailurePropagationOnSeek (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.ReadFailure (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.ReadNothing (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.ReadSuccess (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.SeekEmpty (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.SeekMoreThanAvailable (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.SeekToMiddle (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.SeekToMiddleInSteps (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamReaderTest.SkipFailurePropagationOnSeek (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.CheckContentsReadCorrectly (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.DoesNotCrashWhenExceptionThrown (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.ReadEmptyStream (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.ReadLargeStreamCompletely (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.ReadLargeStreamPartial (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.ReadStreamCompletely (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.ReadStreamPartial (UNKNOWN) C 13.920s Main [ FAILED ] InputStreamTest.TryReadMoreThanBuffer (UNKNOWN) C 13.921s Main [ FAILED ] MediaAccessPermissionRequestTest.TestDenyPermissionRequest (UNKNOWN) C 13.921s Main [ FAILED ] MediaAccessPermissionRequestTest.TestGrantPermissionRequest (UNKNOWN) C 13.921s Main [ FAILED ] MediaAccessPermissionRequestTest.TestGrantPermissionRequestWithoutID (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestMultiplePermissionRequest (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestOriginNotPreauthorized (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestPermissionDenied (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestPermissionGranted (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestPreauthorizeMultiplePermission (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestPreauthorizePermission (UNKNOWN) C 13.921s Main [ FAILED ] PermissionRequestHandlerTest.TestResourcesNotPreauthorized (UNKNOWN) C 13.921s Main C 13.921s Main 81 FAILED TESTS C 13.921s Main ******************************************************************************** On Tue, Mar 1, 2016 at 3:20 PM, <jbudorick@chromium.org> wrote: > On 2016/03/01 23:19:15, jbudorick wrote: > > Yay! lgtm w/ nits > > (but back out the android_webview changes before landing, obviously) > > > > > > > https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... > > File build/android/pylib/gtest/gtest_test_instance.py (right): > > > > > > https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... > > build/android/pylib/gtest/gtest_test_instance.py:214: > > nit: remove these two blank lines > > > > > > https://codereview.chromium.org/1703863003/diff/100001/build/android/pylib/gt... > > build/android/pylib/gtest/gtest_test_instance.py:382: # Needs another > matcher > > here to match crashess, like those of DCHECK. > > nit: s/crashess/crashes/ > > > > https://codereview.chromium.org/1703863003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by hzl@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/1703863003/#ps120001 (title: "fixes! Took away the exception.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703863003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703863003/120001
Message was sent while issue was closed.
Description was changed from ========== Created separate shards for suspicious testcases. In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase. BUG=581086 ========== to ========== Created separate shards for suspicious testcases. In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase. BUG=581086 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Created separate shards for suspicious testcases. In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase. BUG=581086 ========== to ========== Created separate shards for suspicious testcases. In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase. BUG=581086 Committed: https://crrev.com/09361b7a2000298da27d831553547eed54a6f894 Cr-Commit-Position: refs/heads/master@{#379987} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/09361b7a2000298da27d831553547eed54a6f894 Cr-Commit-Position: refs/heads/master@{#379987}
Message was sent while issue was closed.
Just came across this. Thank you! \o/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
