Created separate shards for suspicious testcases.

build/android/pylib/gtest/gtest_test_instance.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import re
 import tempfile
 
 from devil.android import apk_helper
@@ skipping 188 matching lines @@
         self._app_data_file_dir = args.app_data_file_dir
       else:
         self._app_data_file_dir = tempfile.mkdtemp()
         logging.critical('Saving app files to %s', self._app_data_file_dir)
     else:
       self._app_data_files = None
       self._app_data_file_dir = None
 
     self._test_arguments = args.test_arguments
 
+    # Crash detection constants.
+    self._TEST_ERROR_RE = re.compile(r'FAILURES!!! Tests run: \d+,'

[jbudorick, 2016/03/01 05:05:26]

not class-scope constants, top level module-scope constants.

+                                     r' Failures: \d+, Errors: 1')
+    self._TEST_CURRENTLY_RUNNING_RE = re.compile(r'\[ERROR:.*?\]'
+                                                 r' Currently running: (.*)')
+    self._TEST_RUN_RE = re.compile(r'\[ RUN      \] (.*)')
+    self._TEST_CRASH_TAG = '[ CRASHED      ]'
+
   @property
   def activity(self):
     return self._apk_helper and self._apk_helper.GetActivityName()
 
   @property
   def apk(self):
     return self._apk_helper and self._apk_helper.path
 
   @property
   def apk_helper(self):
@@ skipping 117 matching lines @@
         host_paths.DIR_SOURCE_ROOT, 'build', 'android', 'pylib', 'gtest',
         'filter', '%s_disabled' % self._suite)
     if disabled_tests_file_path and os.path.exists(disabled_tests_file_path):
       with open(disabled_tests_file_path) as disabled_tests_file:
         disabled_filter_items += [
             '%s' % l for l in (line.strip() for line in disabled_tests_file)
             if l and not l.startswith('#')]
 
     return '*-%s' % ':'.join(disabled_filter_items)
 
+  def GetCrashedTestCase(self, output):
+    crash_happened = self._TEST_ERROR_RE.search(output[-1])
+    if not crash_happened:
+      return
+    # Crashes that will cause output like DCHECK(false).
+    has_crash = self._TEST_CURRENTLY_RUNNING_RE.search(output[-3])

[jbudorick, 2016/03/01 05:05:26]

Can we either document this -3 or check for _TEST_CURRENTLY_RUNNING_RE matches
in a more robust way?

+    if has_crash:
+      return has_crash.group(1)
+
+    # Crashes that will cause output like null pointer dereference.
+    index = -1 if not self._TEST_CRASH_TAG in output \

[jbudorick, 2016/03/01 05:05:26]

Do we need to check all of output for _TEST_CRASH_TAG, or will is always appear
in the last line if it appears at all?

also, nit: use parentheses to wrap multi-line statements rather than continuing
lines with \

+        else output.index(self._TEST_CRASH_TAG)
+    if not index == -1:
+      run_info = self._TEST_RUN_RE.search(output[index-1])

[jbudorick, 2016/03/01 05:05:26]

I think this should scan up until it finds a match rather than solely checking
index-1

+      if run_info:
+        return run_info.group(1)
+
   # pylint: disable=no-self-use
   def ParseGTestOutput(self, output):
     """Parses raw gtest output and returns a list of results.
 
     Args:
       output: A list of output lines.
     Returns:
       A list of base_test_result.BaseTestResults.
     """
     log = []
@@ skipping 14 matching lines @@
         log.append(l)
 
       if result_type:
         test_name = matcher.group(2)
         duration = int(matcher.group(3)) if matcher.group(3) else 0
         results.append(base_test_result.BaseTestResult(
             test_name, result_type, duration,
             log=('\n'.join(log) if log else '')))
         log = None
         result_type = None
-
+    crashed_test_case = self.GetCrashedTestCase(output)
+    if crashed_test_case:
+      results.append(base_test_result.BaseTestResult(crashed_test_case, \

[jbudorick, 2016/03/01 05:05:26]

nit: again, no \

+                                      base_test_result.ResultType.CRASH))
     return results
 
   #override
   def TearDown(self):
     """Clear the mappings created by SetUp."""
     if self._isolate_delegate:
       self._isolate_delegate.Clear()