Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/heap/incremental-marking.h

Issue 1703823002: Replace slots buffer with remembered set. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/incremental-marking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HEAP_INCREMENTAL_MARKING_H_ 5 #ifndef V8_HEAP_INCREMENTAL_MARKING_H_
6 #define V8_HEAP_INCREMENTAL_MARKING_H_ 6 #define V8_HEAP_INCREMENTAL_MARKING_H_
7 7
8 #include "src/cancelable-task.h" 8 #include "src/cancelable-task.h"
9 #include "src/execution.h" 9 #include "src/execution.h"
10 #include "src/heap/heap.h" 10 #include "src/heap/heap.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 Isolate* isolate); 158 Isolate* isolate);
159 159
160 // Record a slot for compaction. Returns false for objects that are 160 // Record a slot for compaction. Returns false for objects that are
161 // guaranteed to be rescanned or not guaranteed to survive. 161 // guaranteed to be rescanned or not guaranteed to survive.
162 // 162 //
163 // No slots in white objects should be recorded, as some slots are typed and 163 // No slots in white objects should be recorded, as some slots are typed and
164 // cannot be interpreted correctly if the underlying object does not survive 164 // cannot be interpreted correctly if the underlying object does not survive
165 // the incremental cycle (stays white). 165 // the incremental cycle (stays white).
166 INLINE(bool BaseRecordWrite(HeapObject* obj, Object* value)); 166 INLINE(bool BaseRecordWrite(HeapObject* obj, Object* value));
167 INLINE(void RecordWrite(HeapObject* obj, Object** slot, Object* value)); 167 INLINE(void RecordWrite(HeapObject* obj, Object** slot, Object* value));
168 INLINE(void RecordWriteIntoCode(HeapObject* obj, RelocInfo* rinfo, 168 INLINE(void RecordWriteIntoCode(Code* host, RelocInfo* rinfo, Object* value));
169 Object* value));
170 INLINE(void RecordWriteOfCodeEntry(JSFunction* host, Object** slot, 169 INLINE(void RecordWriteOfCodeEntry(JSFunction* host, Object** slot,
171 Code* value)); 170 Code* value));
172 171
173 172
174 void RecordWriteSlow(HeapObject* obj, Object** slot, Object* value); 173 void RecordWriteSlow(HeapObject* obj, Object** slot, Object* value);
175 void RecordWriteIntoCodeSlow(HeapObject* obj, RelocInfo* rinfo, 174 void RecordWriteIntoCodeSlow(Code* host, RelocInfo* rinfo, Object* value);
176 Object* value);
177 void RecordWriteOfCodeEntrySlow(JSFunction* host, Object** slot, Code* value); 175 void RecordWriteOfCodeEntrySlow(JSFunction* host, Object** slot, Code* value);
178 void RecordCodeTargetPatch(Code* host, Address pc, HeapObject* value); 176 void RecordCodeTargetPatch(Code* host, Address pc, HeapObject* value);
179 void RecordCodeTargetPatch(Address pc, HeapObject* value); 177 void RecordCodeTargetPatch(Address pc, HeapObject* value);
180 178
181 void RecordWrites(HeapObject* obj); 179 void RecordWrites(HeapObject* obj);
182 180
183 void BlackToGreyAndUnshift(HeapObject* obj, MarkBit mark_bit); 181 void BlackToGreyAndUnshift(HeapObject* obj, MarkBit mark_bit);
184 182
185 void WhiteToGreyAndPush(HeapObject* obj, MarkBit mark_bit); 183 void WhiteToGreyAndPush(HeapObject* obj, MarkBit mark_bit);
186 184
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 GCRequestType request_type_; 299 GCRequestType request_type_;
302 300
303 IncrementalMarkingJob incremental_marking_job_; 301 IncrementalMarkingJob incremental_marking_job_;
304 302
305 DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking); 303 DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking);
306 }; 304 };
307 } // namespace internal 305 } // namespace internal
308 } // namespace v8 306 } // namespace v8
309 307
310 #endif // V8_HEAP_INCREMENTAL_MARKING_H_ 308 #endif // V8_HEAP_INCREMENTAL_MARKING_H_
OLDNEW
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698