Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(120)

Issue 1703733002: Store device salt callback instead of resource context in WebRTC Audio Private API (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Store device salt callback instead of resource context in WebRTC Audio Private API The resource context pointer was used only to get access to the device ID salt callback. However, the resource context pointer can become dangling and cause use-after-free issues. BUG=572224 Review URL: https://codereview.chromium.org/1692913003 Cr-Commit-Position: refs/heads/master@{#375259} (cherry picked from commit c4e893a3352c34e1a22ec6afad115887a69f576e) Committed: https://chromium.googlesource.com/chromium/src/+/048b308e940105b66e242ec9e0e2efe7d7adf0a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 7 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
4 years, 1 month ago (2016-02-17 00:20:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
048b308e940105b66e242ec9e0e2efe7d7adf0a4.

Powered by Google App Engine
This is Rietveld 408576698