Chromium Code Reviews

Issue 1692913003: Store device salt callback instead of resource context in WebRTC Audio Private API (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
Reviewers:
Marijn Kruisselbrink
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store device salt callback instead of resource context in WebRTC Audio Private API The resource context pointer was used only to get access to the device ID salt callback. However, the resource context pointer can become dangling and cause use-after-free issues. BUG=572224 Committed: https://crrev.com/c4e893a3352c34e1a22ec6afad115887a69f576e Cr-Commit-Position: refs/heads/master@{#375259}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+22 lines, -32 lines)
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 2 chunks +7 lines, -10 lines 0 comments
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 7 chunks +15 lines, -22 lines 0 comments

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692913003/1
4 years, 10 months ago (2016-02-12 17:37:40 UTC) #2
Guido Urdaneta
Hi, PTAL
4 years, 10 months ago (2016-02-12 19:07:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 19:18:24 UTC) #6
Marijn Kruisselbrink
lgtm
4 years, 10 months ago (2016-02-12 19:18:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692913003/1
4 years, 10 months ago (2016-02-12 21:25:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 21:30:37 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:45:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4e893a3352c34e1a22ec6afad115887a69f576e
Cr-Commit-Position: refs/heads/master@{#375259}

Powered by Google App Engine