tools/clang/plugins/ChromeClassTester.h - Issue 1703713002: clang-plugin: Enable RecursiveASTVisitor approach by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/ChromeClassTester.h

Issue 1703713002: clang-plugin: Enable RecursiveASTVisitor approach by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/plugins/ChromeClassTester.h

diff --git a/tools/clang/plugins/ChromeClassTester.h b/tools/clang/plugins/ChromeClassTester.h

index e3d7e3caab209d83eda315c16fc86de14ed7134c..74013db990936d60dff28e8ce5fe4c379f096a5d 100644

--- a/tools/clang/plugins/ChromeClassTester.h

+++ b/tools/clang/plugins/ChromeClassTester.h

@@ -15,6 +15,8 @@

// A class on top of ASTConsumer that forwards classes defined in Chromium

// headers to subclasses which implement CheckChromeClass().

+// TODO(vmpstr): Remove the clang::ASTConsumer base and fold this class into

dcheng 2016/02/16 23:03:50 Can we just remove the base class now?

vmpstr 2016/02/16 23:13:27 Yep! Done.

+// FindBadConstructsConsumer.

class ChromeClassTester : public clang::ASTConsumer {

public:

ChromeClassTester(clang::CompilerInstance& instance,

« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsAction.cpp » ('j') | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('J')